Improve substitution performance by fixing type instabilities #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Current coverage is 70.20% (diff: 100%)@@ master #2 diff @@
==========================================
Files 12 12
Lines 697 698 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 494 490 -4
- Misses 203 208 +5
Partials 0 0
|
blegat
reviewed
Nov 30, 2016
| @@ -1,5 +1,5 @@ | |||
| function evalmap(vars, x::Vector, varorder::Vector{PolyVar}) | |||
| vals = Any[var for var in vars] | |||
| function evalmap{T}(vars, x::Vector{T}, varorder::Vector{PolyVar}) | |||
Member
There was a problem hiding this comment.
Should we do a shortcut like:
if vars == varorder
x
else
... # current body of evalmap
end
?
rdeits
force-pushed
the
performance-improvements
branch
from
899b325 to
31d4262
Compare
1 similar comment
Collaborator
Author
|
Okay, this has been rebased and cleaned up. |
Member
|
Thanks a lot for looking into this ! |
Collaborator
Author
|
No problem :). Optimizing julia code is surprisingly satisfying. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This yields about a 10x improvement in substitution time on my simple benchmark (included in perf/runbenchmarks.jl).