-
Notifications
You must be signed in to change notification settings - Fork 34
Fix @polyvar macro when package is imported
#1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Current coverage is 70.87% (diff: 100%)@@ master #1 diff @@
==========================================
Files 12 12
Lines 697 697
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 494 494
Misses 203 203
Partials 0 0
|
|
Good catch ! |
test/mono.jl
Outdated
| @fact MonomialVector([x]) --> MonomialVector([x], [[1]]) | ||
| end | ||
| module newmodule | ||
| using FactCheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you use 4 spaces indent here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
dd0d46f to
27b0eb7
Compare
|
Ok, this one is rebased. |
@polyvar xonly works when the package has been included withusing, rather thanimport, because it tries to use thePolyVar()defined in the context in which the macro is called, rather than the context in which it was defined. This change should fix that.