Skip to content

Conversation

@rdeits
Copy link
Collaborator

@rdeits rdeits commented Nov 29, 2016

@polyvar x only works when the package has been included with using, rather than import, because it tries to use the PolyVar() defined in the context in which the macro is called, rather than the context in which it was defined. This change should fix that.

@codecov-io
Copy link

codecov-io commented Nov 30, 2016

Current coverage is 70.87% (diff: 100%)

Merging #1 into master will not change coverage

@@             master         #1   diff @@
==========================================
  Files            12         12          
  Lines           697        697          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            494        494          
  Misses          203        203          
  Partials          0          0          

Powered by Codecov. Last update dbf3a3a...3f2dab8

@coveralls
Copy link

coveralls commented Nov 30, 2016

Coverage Status

Coverage remained the same at 71.037% when pulling dd0d46f on macro-hygiene into 98be11f on master.

@blegat
Copy link
Member

blegat commented Nov 30, 2016

Good catch !
I know that my package has an indentation mixed between 4 spaces and 2 spaces but I am trying to convert everything to 4 spaces :)

test/mono.jl Outdated
@fact MonomialVector([x]) --> MonomialVector([x], [[1]])
end
module newmodule
using FactCheck
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use 4 spaces indent here ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@blegat
Copy link
Member

blegat commented Nov 30, 2016

I did the big reindent commit before merging your pull requests so that git blame remains accurate. Could you rebase #1 #2 ?

@rdeits
Copy link
Collaborator Author

rdeits commented Nov 30, 2016

Ok, this one is rebased.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.875% when pulling 3f2dab8 on macro-hygiene into dbf3a3a on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.875% when pulling 3f2dab8 on macro-hygiene into dbf3a3a on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.875% when pulling 3f2dab8 on macro-hygiene into dbf3a3a on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.875% when pulling 3f2dab8 on macro-hygiene into dbf3a3a on master.

@blegat blegat merged commit 4162fa7 into master Nov 30, 2016
@saschatimme saschatimme deleted the macro-hygiene branch September 24, 2018 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants