Skip to content

Delete top level babbage command group #1117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 5, 2025
Merged

Delete top level babbage command group #1117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4ad42f2
Delete top-level allegra command group and asssociated tests
newhoggy Mar 29, 2025
2b8ad1f
Delete top-level mary command group and delete associated tests
newhoggy Mar 29, 2025
34ab3f7
Delete top-level alonzo command group and delete associated tests
newhoggy Mar 30, 2025
cbe4ee6
Delete top-level babbage command group and delete associated tests
newhoggy Mar 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
7 changes: 0 additions & 7 deletions cardano-cli/cardano-cli.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,9 +465,6 @@ test-suite cardano-cli-golden
Test.Golden.Conway.Transaction.CreateWitness
Test.Golden.CreateStaked
Test.Golden.CreateTestnetData
Test.Golden.EraBased.Governance.AnswerPoll
Test.Golden.EraBased.Governance.CreatePoll
Test.Golden.EraBased.Governance.VerifyPoll
Test.Golden.ErrorsSpec
Test.Golden.Governance.Action
Test.Golden.Governance.Committee
Expand Down Expand Up @@ -500,10 +497,7 @@ test-suite cardano-cli-golden
Test.Golden.Shelley.StakeAddress.RegistrationCertificate
Test.Golden.Shelley.StakePool.RegistrationCertificate
Test.Golden.Shelley.TextEnvelope.Certificates.GenesisKeyDelegation
Test.Golden.Shelley.TextEnvelope.Certificates.MIR
Test.Golden.Shelley.TextEnvelope.Certificates.Operational
Test.Golden.Shelley.TextEnvelope.Certificates.StakeAddress
Test.Golden.Shelley.TextEnvelope.Certificates.StakePool
Test.Golden.Shelley.TextEnvelope.Keys.ExtendedPaymentKeys
Test.Golden.Shelley.TextEnvelope.Keys.GenesisDelegateKeys
Test.Golden.Shelley.TextEnvelope.Keys.GenesisKeys
Expand All @@ -513,7 +507,6 @@ test-suite cardano-cli-golden
Test.Golden.Shelley.TextEnvelope.Keys.StakeKeys
Test.Golden.Shelley.TextEnvelope.Keys.VRFKeys
Test.Golden.Shelley.TextEnvelope.Tx.Tx
Test.Golden.Shelley.TextEnvelope.Tx.TxBody
Test.Golden.Shelley.TextEnvelope.Tx.Witness
Test.Golden.Shelley.TextView.DecodeCbor
Test.Golden.Shelley.Transaction.Assemble
Expand Down
21 changes: 1 addition & 20 deletions cardano-cli/src/Cardano/CLI/EraBased/Option.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import Cardano.Api (ShelleyBasedEra (..))

import Cardano.CLI.Environment
import Cardano.CLI.EraBased.Command
import Cardano.CLI.EraBased.Common.Option
import Cardano.CLI.EraBased.Genesis.Option
import Cardano.CLI.EraBased.Governance.Option (pGovernanceCmds)
import Cardano.CLI.EraBased.Query.Option
Expand Down Expand Up @@ -45,25 +44,7 @@ pCmds era envCli = do
pAnyEraCommand :: EnvCli -> Parser AnyEraCommand
pAnyEraCommand envCli =
asum
[ -- Note, byron is ommitted because there is already a legacy command group for it.

Opt.hsubparser $
commandWithMetavar "allegra" $
Opt.info (AnyEraCommandOf ShelleyBasedEraAllegra <$> pCmds ShelleyBasedEraAllegra envCli) $
Opt.progDesc ("Allegra era commands" <> deprecationText)
, Opt.hsubparser $
commandWithMetavar "mary" $
Opt.info (AnyEraCommandOf ShelleyBasedEraMary <$> pCmds ShelleyBasedEraMary envCli) $
Opt.progDesc ("Mary era commands" <> deprecationText)
, Opt.hsubparser $
commandWithMetavar "alonzo" $
Opt.info (AnyEraCommandOf ShelleyBasedEraAlonzo <$> pCmds ShelleyBasedEraAlonzo envCli) $
Opt.progDesc ("Alonzo era commands" <> deprecationText)
, Opt.hsubparser $
commandWithMetavar "babbage" $
Opt.info (AnyEraCommandOf ShelleyBasedEraBabbage <$> pCmds ShelleyBasedEraBabbage envCli) $
Opt.progDesc ("Babbage era commands" <> deprecationText)
, Opt.hsubparser $
[ Opt.hsubparser $
commandWithMetavar "conway" $
Opt.info (AnyEraCommandOf ShelleyBasedEraConway <$> pCmds ShelleyBasedEraConway envCli) $
Opt.progDesc "Conway era commands"
Expand Down
4 changes: 2 additions & 2 deletions cardano-cli/test/cardano-cli-golden/Test/Golden/Babbage/Transaction/CalculateMinFee.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ hprop_golden_babbage_transaction_calculate_min_fee :: Property
hprop_golden_babbage_transaction_calculate_min_fee = propertyOnce $ do
protocolParamsJsonFile <-
noteInputFile
"test/cardano-cli-golden/files/input/babbage/transaction-calculate-min-fee/protocol-params.json"
txBodyFile <- noteInputFile "test/cardano-cli-golden/files/input/babbage/tx/txbody"
"test/cardano-cli-golden/files/input/conway/transaction-calculate-min-fee/protocol-params.json"
txBodyFile <- noteInputFile "test/cardano-cli-golden/files/input/conway/tx/txbody"

minFeeTxt <-
execCardanoCLI
Expand Down
103 changes: 0 additions & 103 deletions cardano-cli/test/cardano-cli-golden/Test/Golden/EraBased/Governance/AnswerPoll.hs
View file
Open in desktop

This file was deleted.

74 changes: 0 additions & 74 deletions cardano-cli/test/cardano-cli-golden/Test/Golden/EraBased/Governance/CreatePoll.hs
View file
Open in desktop

This file was deleted.

121 changes: 0 additions & 121 deletions cardano-cli/test/cardano-cli-golden/Test/Golden/EraBased/Governance/VerifyPoll.hs
View file
Open in desktop

This file was deleted.

Loading
Loading