Skip to content

Delete top level babbage command group #1117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 5, 2025
Merged

Delete top level babbage command group #1117

merged 4 commits into from
Apr 5, 2025

Conversation

@newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Mar 30, 2025 •
edited
Loading

Changelog

- description: |
    Delete top level `babbage` command group
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

newhoggy
newhoggy commented Mar 30, 2025
View reviewed changes
cardano-cli/test/cardano-cli-golden/Test/Golden/TxView.hs
scriptTxBody :: FilePath -> Integration ()
scriptTxBody transactionBodyFile =
void $
execCardanoCLI
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fails with:

      ✗ Test.Golden.TxView.hprop_golden_view_redeemer failed at test/cardano-cli-golden/Test/Golden/TxView.hs:111:7
        after 1 test.
        shrink path: 1:
      
            ┏━━ test/cardano-cli-golden/Test/Golden/TxView.hs ━━━
         94 ┃ hprop_golden_view_redeemer :: Property
         95 ┃ hprop_golden_view_redeemer = do
         96 ┃   propertyOnce $
         97 ┃     moduleWorkspace "tmp" $ \tempDir -> do
            ┃     │ Workspace: /tmp/tmp-Test.Golden.TxView-test-9d0e749d0d4e1385
         98 ┃       transactionBodyFile <- noteTempFile tempDir "transaction-body-file"
            ┃       │ cardano-cli//tmp/tmp-Test.Golden.TxView-test-9d0e749d0d4e1385/transaction-body-file
         99 ┃       scriptTxBody transactionBodyFile
        100 ┃ 
        101 ┃       -- View transaction body
        102 ┃       result <-
        103 ┃         execCardanoCLI
        104 ┃           ["debug", "transaction", "view", "--tx-body-file", transactionBodyFile, "--output-yaml"]
        105 ┃ 
        106 ┃       H.diffVsGoldenFile result $ goldenDir </> "conway/transaction-view-redeemer.out"
        107 ┃  where
        108 ┃   scriptTxBody :: FilePath -> Integration ()
        109 ┃   scriptTxBody transactionBodyFile =
        110 ┃     void $
        111 ┃       execCardanoCLI
            ┃       │ ━━━━ command ━━━━
            ┃       │ /home/jky/wrk/intersect/cardano-cli/dist-newstyle/build/x86_64-linux/ghc-9.10.1/cardano-cli-10.5.0.0/x/cardano-cli/build/cardano-cli/cardano-cli conway transaction build-raw --tx-in ed7c8f68c194cc763ee65ad22ef0973e26481be058c65005fd39fb93f9c43a20#213 --tx-in-datum-value 6666 --tx-in-redeemer-value 42 --tx-in-script-file test/cardano-cli-golden/files/input/AlwaysSucceeds.plutus --tx-in-execution-units "(100, 200)" --tx-in-collateral c9765d7d0e3955be8920e6d7a38e1f3f2032eac48c7c59b0b9193caa87727e7e#256 --protocol-params-file test/cardano-cli-golden/files/input/conway/transaction-calculate-min-fee/protocol-params.json --fee 213 --out-file /tmp/tmp-Test.Golden.TxView-test-9d0e749d0d4e1385/transaction-body-file
            ┃       │ Process exited with non-zero exit-code: 1
            ┃       │ ━━━━ stderr ━━━━
            ┃       │ Command failed: transaction build-raw
            ┃       │ Error: Error while decoding the protocol parameters at: "test/cardano-cli-golden/files/input/conway/transaction-calculate-min-fee/protocol-params.json" Error: "Error in $: key \"poolVotingThresholds\" not found"
            ┃       │ 
            ┃       ^^^^^^^^^^^^^^
            ┃       │ Execute process failed

@newhoggy newhoggy force-pushed the newhoggy/delete-top-level-babbage-command-group branch from 02f0bf0 to 6bcf059 Compare March 30, 2025 03:05
newhoggy
newhoggy commented Mar 30, 2025
View reviewed changes
cardano-cli/test/cardano-cli-golden/Test/Golden/Shelley/Transaction/Build.hs
txBodyOutFile <- noteTempFile tempDir "tx-body-out"

void $
execCardanoCLI
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fails with:

           ┏━━ test/cardano-cli-golden/Test/Golden/Shelley/Transaction/Build.hs ━━━
        48 ┃ hprop_golden_shelley_transaction_build_certificate_script_witnessed :: Property
        49 ┃ hprop_golden_shelley_transaction_build_certificate_script_witnessed =
        50 ┃   propertyOnce $ H.moduleWorkspace "tmp" $ \tempDir -> do
           ┃   │ Workspace: /tmp/tmp-Test.Golden.Shelley.Transaction.Build-test-fa8223f991df8f93
        51 ┃     let deregcert =
        52 ┃           "test/cardano-cli-golden/files/input/shelley/certificates/stake_address_deregistration_certificate"
        53 ┃         scriptWit = "test/cardano-cli-golden/files/input/shelley/multisig/scripts/any"
        54 ┃ 
        55 ┃     txBodyOutFile <- noteTempFile tempDir "tx-body-out"
           ┃     │ cardano-cli//tmp/tmp-Test.Golden.Shelley.Transaction.Build-test-fa8223f991df8f93/tx-body-out
        56 ┃ 
        57 ┃     void $
        58 ┃       execCardanoCLI
           ┃       │ ━━━━ command ━━━━
           ┃       │ /home/jky/wrk/intersect/cardano-cli/dist-newstyle/build/x86_64-linux/ghc-9.10.1/cardano-cli-10.5.0.0/x/cardano-cli/build/cardano-cli/cardano-cli conway transaction build-raw --tx-in 2392d2b1200b5139fe555c81261697b29a8ccf561c5c783d46e78a479d977053#0 --tx-out addr1q94cxl99qvtwunsqqv6g9mgj3zrawtpt4edsgwxkjtwpy5dsezcht90tmwfur7t5hc9fk8hjd3r5vjwec2h8vmk3xh8s7er7t3+100 --certificate-file test/cardano-cli-golden/files/input/shelley/certificates/stake_address_deregistration_certificate --certificate-script-file test/cardano-cli-golden/files/input/shelley/multisig/scripts/any --fee 12 --tx-body-file /tmp/tmp-Test.Golden.Shelley.Transaction.Build-test-fa8223f991df8f93/tx-body-out
           ┃       │ Process exited with non-zero exit-code: 1
           ┃       │ ━━━━ stderr ━━━━
           ┃       │ Command failed: transaction build-raw
           ┃       │ Error: test/cardano-cli-golden/files/input/shelley/certificates/stake_address_deregistration_certificate: TextEnvelope type error:  Expected: CertificateConway Actual: CertificateShelley
           ┃       │ 
           ┃       ^^^^^^^^^^^^^^
           ┃       │ Execute process failed

@newhoggy newhoggy force-pushed the newhoggy/delete-top-level-babbage-command-group branch from 6bcf059 to 35e23b7 Compare March 30, 2025 03:10
newhoggy
newhoggy commented Mar 30, 2025
View reviewed changes
cardano-cli/test/cardano-cli-golden/Test/Golden/Shelley/TextEnvelope/Certificates/StakePool.hs
checkTextEnvelopeFormat
registrationCertificateType
referenceRegistrationCertificate
registrationCertificate
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fails with:

        126 ┃   checkTextEnvelopeFormat
            ┃   ^^^^^^^^^^^^^^^^^^^^^^^
            ┃   │ /tmp/tmp-Test.Golden.Shelley.TextEnvelope.Certificates.StakePool-test-d529f1472a1ce685/stake-pool-registration-certificate: TextEnvelope type error:  Expected: CertificateShelley Actual: CertificateConway

@newhoggy newhoggy force-pushed the newhoggy/delete-top-level-babbage-command-group branch from 35e23b7 to 6d03d98 Compare March 30, 2025 03:19
newhoggy
newhoggy commented Mar 30, 2025
View reviewed changes
...no-cli/test/cardano-cli-golden/Test/Golden/Shelley/TextEnvelope/Certificates/StakeAddress.hs
checkTextEnvelopeFormat
registrationCertificateType
referenceRegistrationCertificate
registrationCertificate
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fails with:

         76 ┃   checkTextEnvelopeFormat
            ┃   ^^^^^^^^^^^^^^^^^^^^^^^
            ┃   │ test/cardano-cli-golden/files/input/shelley/certificates/stake_address_registration_certificate: TextEnvelope type error:  Expected: CertificateConway Actual: CertificateShelley

@newhoggy newhoggy force-pushed the newhoggy/delete-top-level-babbage-command-group branch from 6d03d98 to e2f35f3 Compare March 30, 2025 03:39
newhoggy
newhoggy commented Mar 30, 2025
View reviewed changes
cardano-cli/test/cardano-cli-golden/Test/Golden/Shelley/TextEnvelope/Certificates/MIR.hs
let testAddr = "stake1u9j6axhcpd0exvrthn5dqzqt54g85akqvkn4uqmccm70qsc5hpv9w"
-- Create MIR certificate
void $
execCardanoCLI
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fails with:

        50 ┃     execCardanoCLI
           ┃     │ ━━━━ command ━━━━
           ┃     │ /home/jky/wrk/intersect/cardano-cli/dist-newstyle/build/x86_64-linux/ghc-9.10.1/cardano-cli-10.5.0.0/x/cardano-cli/build/cardano-cli/cardano-cli conway governance create-mir-certificate --reserves --stake-address stake1u9j6axhcpd0exvrthn5dqzqt54g85akqvkn4uqmccm70qsc5hpv9w --reward 1000 --out-file /tmp/tmp-Test.Golden.Shelley.TextEnvelope.Certificates.MIR-test-d5ed057a2128d2f3/mir-certificate-file
           ┃     │ Process exited with non-zero exit-code: 1
           ┃     │ ━━━━ stderr ━━━━
           ┃     │ Invalid argument `create-mir-certificate'
           ┃     │ 
           ┃     │ Usage: cardano-cli conway governance (action | committee | drep | vote)
           ┃     │ 
           ┃     │   Governance commands.
           ┃     │ 
           ┃     ^^^^^^^^^^^^^^

@newhoggy newhoggy force-pushed the newhoggy/delete-top-level-babbage-command-group branch from e2f35f3 to 2e9bf97 Compare March 30, 2025 03:53
newhoggy
newhoggy commented Mar 30, 2025
View reviewed changes
cardano-cli/test/cardano-cli-golden/Test/Golden/EraBased/Governance/VerifyPoll.hs
<$> execCardanoCLI
[ "babbage"
, "governance"
, "verify-poll"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the tests in this file fail like this:

           ┃       │ ━━━━ command ━━━━
           ┃       │ /home/jky/wrk/intersect/cardano-cli/dist-newstyle/build/x86_64-linux/ghc-9.10.1/cardano-cli-10.5.0.0/x/cardano-cli/build/cardano-cli/cardano-cli conway governance verify-poll --poll-file test/cardano-cli-golden/files/input/governance/polls/basic.json --tx-file test/cardano-cli-golden/files/input/governance/verify/valid
           ┃       │ Process exited with non-zero exit-code: 1
           ┃       │ ━━━━ stderr ━━━━
           ┃       │ Invalid argument `verify-poll'
           ┃       │ 
           ┃       │ Usage: cardano-cli conway governance (action | committee | drep | vote)
           ┃       │ 
           ┃       │   Governance commands.
           ┃       │ 
           ┃       ^^^^^^^^^^^^^^^^^^
           ┃       │ Execute process failed

@newhoggy newhoggy force-pushed the newhoggy/delete-top-level-babbage-command-group branch from 2e9bf97 to 8a0d7d5 Compare March 30, 2025 03:57
newhoggy
newhoggy commented Mar 30, 2025
View reviewed changes
cardano-cli/test/cardano-cli-golden/Test/Golden/EraBased/Governance/CreatePoll.hs
pollFile <- noteTempFile tempDir "poll.json"

stdout <-
execCardanoCLI
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the tests in this file fail like this:

        52 ┃       execCardanoCLI
           ┃       │ ━━━━ command ━━━━
           ┃       │ /home/jky/wrk/intersect/cardano-cli/dist-newstyle/build/x86_64-linux/ghc-9.10.1/cardano-cli-10.5.0.0/x/cardano-cli/build/cardano-cli/cardano-cli conway governance create-poll --question "What is the most adequate topping to put on a pizza (please consider all possibilities and take time to answer)?" --answer pineapples --answer "only traditional topics should go on a pizza, this isn't room for jokes" --out-file /tmp/tmp-Test.Golden.EraBased.Governance.CreatePoll-test-d31e174ef726f950/poll.json
           ┃       │ Process exited with non-zero exit-code: 1
           ┃       │ ━━━━ stderr ━━━━
           ┃       │ Invalid argument `create-poll'
           ┃       │ 
           ┃       │ Usage: cardano-cli conway governance (action | committee | drep | vote)
           ┃       │ 
           ┃       │   Governance commands.
           ┃       │ 
           ┃       ^^^^^^^^^^^^^^

@newhoggy newhoggy force-pushed the newhoggy/delete-top-level-babbage-command-group branch from 8a0d7d5 to 874c983 Compare March 30, 2025 04:02
newhoggy
newhoggy commented Mar 30, 2025
View reviewed changes
cardano-cli/test/cardano-cli-golden/Test/Golden/EraBased/Governance/AnswerPoll.hs
outFile <- H.noteTempFile tempDir "answer-file.json"

result <-
tryExecCardanoCLI
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the tests in this file fail like this:

        69 ┃     execCardanoCLI
           ┃     │ ━━━━ command ━━━━
           ┃     │ /home/jky/wrk/intersect/cardano-cli/dist-newstyle/build/x86_64-linux/ghc-9.10.1/cardano-cli-10.5.0.0/x/cardano-cli/build/cardano-cli/cardano-cli conway governance answer-poll --poll-file test/cardano-cli-golden/files/input/governance/polls/basic.json --answer 1 --out-file /tmp/governance-answer-poll-Test.Golden.EraBased.Governance.AnswerPoll-test-9bfed09f7006ee62/answer-file.json
           ┃     │ Process exited with non-zero exit-code: 1
           ┃     │ ━━━━ stderr ━━━━
           ┃     │ Invalid argument `answer-poll'
           ┃     │ 
           ┃     │ Usage: cardano-cli conway governance (action | committee | drep | vote)
           ┃     │ 
           ┃     │   Governance commands.
           ┃     │ 
           ┃     ^^^^^^^^^^^^^^
           ┃     │ Execute process failed

@newhoggy newhoggy force-pushed the newhoggy/delete-top-level-babbage-command-group branch 2 times, most recently from 0a66dd0 to 5a76a29 Compare March 31, 2025 12:35
Jimbo4350
Jimbo4350 approved these changes Apr 3, 2025
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We need to switch to the latest command group in the cli tests.

@newhoggy newhoggy force-pushed the newhoggy/delete-top-level-babbage-command-group branch from 5a76a29 to f31b11a Compare April 4, 2025 14:12
@newhoggy newhoggy enabled auto-merge April 4, 2025 15:09
@newhoggy newhoggy force-pushed the newhoggy/delete-top-level-babbage-command-group branch from f31b11a to cbe4ee6 Compare April 5, 2025 00:32
@newhoggy newhoggy added this pull request to the merge queue Apr 5, 2025
Merged via the queue into master with commit d8357da Apr 5, 2025
26 checks passed
@newhoggy newhoggy deleted the newhoggy/delete-top-level-babbage-command-group branch April 5, 2025 01:51
@Jimbo4350 Jimbo4350 mentioned this pull request Apr 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@carbolymer carbolymer Awaiting requested review from carbolymer carbolymer is a code owner

@smelc smelc Awaiting requested review from smelc

@palas palas Awaiting requested review from palas palas is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@newhoggy @Jimbo4350