Skip to content

Release 10.3 #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 2, 2025
Merged

Release 10.3 #1075

merged 4 commits into from
Apr 2, 2025

Conversation

@aniketd
Copy link
Contributor

@aniketd aniketd commented Feb 28, 2025 •
edited by palas
Loading

Changelog

- description: |
    Bumped ledger and dependencies for node 10.3 release.
      * Removed use of parameterised crypto (`EraCrypto c`, this enables many other data types to become mono-morphic over `StandardCrypto`)
      * Added `query stake-pool-default-vote`
      * Ensured security parameter is non-zero
  type:
  - breaking
  - feature

Context

TODO

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@aniketd aniketd force-pushed the aniketd/release-10-3 branch from 978382e to 9006b84 Compare March 6, 2025 13:05
@aniketd aniketd marked this pull request as ready for review March 6, 2025 13:11
Jimbo4350
Jimbo4350 approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aniketd aniketd force-pushed the aniketd/release-10-3 branch from 9006b84 to 98918f8 Compare March 27, 2025 13:30
@aniketd aniketd requested a review from Jimbo4350 March 27, 2025 14:00
Jimbo4350
Jimbo4350 reviewed Mar 28, 2025
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! #1081 (review) needs to be merged then the commit history cleaned up (remove SRPs). I will approve after.

@aniketd aniketd force-pushed the aniketd/release-10-3 branch 2 times, most recently from b01821a to e9e0d01 Compare March 30, 2025 16:03
carbolymer
carbolymer reviewed Mar 31, 2025
View reviewed changes
carbolymer
carbolymer approved these changes Mar 31, 2025
View reviewed changes
Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Few small issues:

  • You need to sign your commits
  • cardano-ping:base should get included in allow-newer like IntersectMBO/cardano-api#758 (comment)
  • You need to regenerate golden files: RECREATE_GOLDEN_FILES=1 cabal test cardano-cli

@aniketd aniketd force-pushed the aniketd/release-10-3 branch from 9306cc3 to 3812894 Compare March 31, 2025 12:13
@aniketd aniketd force-pushed the aniketd/release-10-3 branch from 3812894 to 6e62c0b Compare March 31, 2025 12:17
@aniketd aniketd requested a review from carbolymer March 31, 2025 12:17
@aniketd
Copy link
Contributor Author

aniketd commented Mar 31, 2025

@carbolymer I have resolved all your suggestions in the review 🙂 Thanks! This is ready for another final review and merge. 👍

@aniketd aniketd requested a review from Jimbo4350 March 31, 2025 12:34
@carbolymer
Copy link
Contributor

@aniketd Thanks. Looks good. I don't know where this hydra error comes from.

@palas palas force-pushed the aniketd/release-10-3 branch from 81d6507 to 04fa427 Compare April 1, 2025 11:08
@palas palas force-pushed the aniketd/release-10-3 branch 2 times, most recently from 483961f to ebc65cf Compare April 1, 2025 11:38
@carbolymer carbolymer mentioned this pull request Apr 1, 2025
Merged
3 tasks
@palas palas force-pushed the aniketd/release-10-3 branch 3 times, most recently from 2d60ba7 to ebc65cf Compare April 2, 2025 13:56
@palas palas added this pull request to the merge queue Apr 2, 2025
Merged via the queue into master with commit 14524f9 Apr 2, 2025
25 checks passed
@palas palas deleted the aniketd/release-10-3 branch April 2, 2025 17:51
@palas palas mentioned this pull request Apr 3, 2025
Merged
3 tasks
palas added a commit that referenced this pull request Apr 3, 2025
@palas
Flesh out change-log entry for PR #1075
6652db5
@newhoggy newhoggy mentioned this pull request Sep 21, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carbolymer carbolymer carbolymer approved these changes

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy is a code owner

@smelc smelc Awaiting requested review from smelc

@palas palas Awaiting requested review from palas palas is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler is a code owner

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350 Jimbo4350 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aniketd @carbolymer @Jimbo4350 @palas @jasagredo