Skip to content

For release 10.3 #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
palas merged 2 commits into from
Mar 28, 2025
Merged

For release 10.3 #758

palas merged 2 commits into from
Mar 28, 2025

Conversation

@aniketd
Copy link
Contributor

@aniketd aniketd commented Feb 21, 2025 •
edited by palas
Loading

Changelog

- description: |
    Bumped ledger and dependencies for node 10.3 release.
      - Removed `queryProtocolParametersUpdate` and the use of parameterised crypto (`EraCrypto c`, this enables many other data types to become mono-morphic over `StandardCrypto`)
      - Added `queryStakePoolDefaultVote` and `queryLedgerConfig`
  type:
  - breaking

Context

This PR is about the ongoing efforts to integration all dependencies towards the 10.3 node release. Expect additional relevant information to be updated as and when necessary.

How to trust this PR

This one needs careful review from the code-owners when it is ready to be merged.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@aniketd aniketd force-pushed the aniketd/release-10-3 branch 2 times, most recently from 5d4a3e5 to cac342f Compare February 23, 2025 11:49
@aniketd aniketd force-pushed the aniketd/release-10-3 branch 2 times, most recently from da28951 to de211ca Compare March 6, 2025 11:39
@aniketd aniketd marked this pull request as ready for review March 6, 2025 11:43
Jimbo4350
Jimbo4350 reviewed Mar 6, 2025
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of comments to discuss then I'll approve.

jasagredo
jasagredo reviewed Mar 6, 2025
View reviewed changes
@aniketd aniketd force-pushed the aniketd/release-10-3 branch from 8c15145 to 1bb1524 Compare March 26, 2025 12:09
@aniketd aniketd requested review from Jimbo4350 and jasagredo March 26, 2025 15:02
Jimbo4350
Jimbo4350 reviewed Mar 26, 2025
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however can you remove all mention of the SRPs from the commit history?

@palas palas self-assigned this Mar 26, 2025
@jasagredo
Copy link
Contributor

jasagredo commented Mar 26, 2025 •
edited
Loading

FYI, you will need to add these to allow-newer for CI to pass for 9.12:

    , ouroboros-network-protocols:base
    , ouroboros-network-framework:base
    , ouroboros-network-api:base
    , network-mux:base
    , ouroboros-network:base

ref

jasagredo
jasagredo previously requested changes Mar 26, 2025
View reviewed changes
@palas
Copy link
Contributor

palas commented Mar 26, 2025

I've added a change-log message in the PR description and marked it as breaking. @aniketd, please check it is accurate and feel free to improve it

@aniketd aniketd force-pushed the aniketd/release-10-3 branch from 632c936 to 8763425 Compare March 27, 2025 10:40
@aniketd aniketd requested review from Jimbo4350 and jasagredo March 27, 2025 10:48
@Jimbo4350
Copy link
Contributor

Jimbo4350 commented Mar 27, 2025

Some conflicts need to be resolved still. Should be straight forward if not I can handle it tomorrow.

carbolymer
carbolymer reviewed Mar 28, 2025
View reviewed changes
Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jimbo4350 Jimbo4350 force-pushed the aniketd/release-10-3 branch from 8763425 to b82a3e3 Compare March 28, 2025 13:07
@jasagredo jasagredo dismissed their stale review March 28, 2025 13:23

Comments addresses

@palas palas enabled auto-merge March 28, 2025 13:24
@palas palas disabled auto-merge March 28, 2025 13:38
@palas palas enabled auto-merge March 28, 2025 13:54
@palas palas added this pull request to the merge queue Mar 28, 2025
Merged via the queue into master with commit b57758b Mar 28, 2025
30 checks passed
@palas palas deleted the aniketd/release-10-3 branch March 28, 2025 14:45
@palas palas mentioned this pull request Mar 28, 2025
Merged
3 tasks
This was referenced Mar 28, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carbolymer carbolymer carbolymer left review comments

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts dcoutts is a code owner

@erikd erikd Awaiting requested review from erikd erikd is a code owner

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy is a code owner

@smelc smelc Awaiting requested review from smelc

@palas palas Awaiting requested review from palas palas is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond is a code owner

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara CarlosLopezDeLara is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler is a code owner

@jasagredo jasagredo Awaiting requested review from jasagredo

Assignees

@palas palas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@aniketd @jasagredo @palas @Jimbo4350 @carbolymer