Skip to content

update dpctl function signature #1775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonwolfy merged 2 commits into from
Apr 6, 2024
Merged

update dpctl function signature #1775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23345cd
update func signature
Apr 5, 2024
b0dfe2f
Use positional argument in validate_usm_type() call
antonwolfy Apr 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dpnp/dpnp_container.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,13 +301,13 @@ def ones(

def tril(x1, /, *, k=0):
"""Creates `dpnp_array` as lower triangular part of an input array."""
array_obj = dpt.tril(dpnp.get_usm_ndarray(x1), k)
array_obj = dpt.tril(dpnp.get_usm_ndarray(x1), k=k)
return dpnp_array(array_obj.shape, buffer=array_obj, order="K")


def triu(x1, /, *, k=0):
"""Creates `dpnp_array` as upper triangular part of an input array."""
array_obj = dpt.triu(dpnp.get_usm_ndarray(x1), k)
array_obj = dpt.triu(dpnp.get_usm_ndarray(x1), k=k)
return dpnp_array(array_obj.shape, buffer=array_obj, order="K")


Expand Down
2 changes: 1 addition & 1 deletion dpnp/dpnp_iface_manipulation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,7 +531,7 @@ def can_cast(from_, to, casting="safe"):
if dpnp.is_supported_array_type(from_)
else dpnp.dtype(from_)
)
return dpt.can_cast(dtype_from, to, casting)
return dpt.can_cast(dtype_from, to, casting=casting)


def column_stack(tup):
Expand Down
2 changes: 1 addition & 1 deletion dpnp/random/dpnp_random_state.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ def normal(
f"scale={scale}, but must be non-negative."
)

dpu.validate_usm_type(usm_type=usm_type, allow_none=False)
dpu.validate_usm_type(usm_type, allow_none=False)
return self._random_state.normal(
loc=loc,
scale=scale,
Expand Down