Skip to content

Conversation

@vtavana
Copy link
Contributor

@vtavana vtavana commented Apr 5, 2024

Due to changes in dpctl-1626, the function signatures of a few functions are modified and positional arguments are converted to keyword-only arguments.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Apr 5, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2024

View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html

@vtavana vtavana marked this pull request as ready for review April 5, 2024 19:50
@antonwolfy antonwolfy merged commit 5bcf9ba into master Apr 6, 2024
@antonwolfy antonwolfy deleted the update_dpt_func_signature branch April 6, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants