Transition dpnp build system to using scikit-build and cmake on all platforms #1349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To build dpnp, one one does ```bash CC=icx CXX=icpx python setup.py develop -G Ninja -- -DDPCTL_MODULE_PATH=$(python -m dpctl --cmakedir) ``` or on Windows ```cmd python setup.py develop -G Ninja -- -DDPCTL_MODULE_PATH=<path> -DCMAKE_C_COMPILER=icx -DCMAKE_CXX_COMPILER=icx ``` where the `<path>` is the output of `python -m dpctl --cmakedir`.
…dpnp_backend_c in target_link_libraries for CTest
Contributor
Author
|
The way to initiate the build is CC=icx CXX=icpx DPL_ROOT_HINT=$DPL_ROOT python setup.py develop -G Ninja -- \
-DDPCTL_MODULE_PATH=$(python -m dpctl --cmakedir) \
-DCMAKE_VERBOSE_MAKEFILE=ON |
…/dpnp into use-skbuild-and-cmake
This must be done to work-around issues in cmake scripts included in the respective tbb-devel and onedpl-devel conda packages.
Also allows find_library in TBBConfig.cmake to find Windows libraries.
Add scripts build locally
Use `sys.executable` instead of `"python"` in `check_output` call
Adds a new github CI Action to generate coverage and upload to coveralls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites build system of
dpnpto usescikit-buildandcmakeon all supported platforms.CMake scripts leverage cmake integration in oneAPI DPC++, oneAPI MKL, oneAPI TBB and oneAPI DPL.
The oneAPI DPL conda packages are not yet packaging their cmake integration scripts, so a remaining to-do list is to vendor that script into
dpnp/backend/cmake/and make sure that it can be found.