Skip to content

Conversation

@oleksandr-pavlyk
Copy link
Contributor

This PR adds scripts/build_locally.py script to drive build of dpnp, and removed legacy scripts 0.build.sh, 0.env.sh and 1.build.bat and 1.env.bat.

Azure scripts using legacy scripts were updated, but I doubt they are working and should probably be removed.

Supported options:

(dev_dpctl) opavlyk@opavlyk-mobl:~/repos/dpnp$ python scripts/build_locally.py --help
usage: build_locally.py [-h] [--c-compiler C_COMPILER] [--cxx-compiler CXX_COMPILER] [--oneapi] [--debug] [--compiler-root COMPILER_ROOT] [--cmake-executable CMAKE_EXECUTABLE]
                        [--verbose] [--cmake-opts CMAKE_OPTS]

Driver to build dpnp for in-place installation

optional arguments:
  -h, --help            show this help message and exit

Coverage driver arguments:
  --c-compiler C_COMPILER
                        Name of C compiler
  --cxx-compiler CXX_COMPILER
                        Name of C++ compiler
  --oneapi              Set if using one-API installation
  --debug               Set the compilation mode to debugging
  --compiler-root COMPILER_ROOT
                        Path to compiler home directory
  --cmake-executable CMAKE_EXECUTABLE
                        Path to cmake executable
  --verbose             Build using vebose makefile mode
  --cmake-opts CMAKE_OPTS
                        Channels through additional cmake options
  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@oleksandr-pavlyk oleksandr-pavlyk changed the base branch from master to use-skbuild-and-cmake April 4, 2023 20:46
Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this script on my laptop(WSL) with OneAPI as a conda package and it works great.
Thank you @oleksandr-pavlyk

@oleksandr-pavlyk oleksandr-pavlyk merged commit e39f7a9 into use-skbuild-and-cmake Apr 5, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the add-scripts-build-locally branch April 5, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants