Extract gmath_nodes from gcore::ops, create mods debug and extract_xy
#2764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firestar99
force-pushed
the
extract_math_nodes
branch
from
4c4f210 to
2d5894f
Compare
Firestar99
force-pushed
the
gsvg_renderer
branch
from
b113ef2 to
bffd562
Compare
Firestar99
force-pushed
the
extract_math_nodes
branch
from
2d5894f to
55e09b7
Compare
Firestar99
changed the title
gmath_nodes from gcore::ops, create mods debug and extract_xy
Firestar99
force-pushed
the
extract_math_nodes
branch
from
55e09b7 to
5eaa7d9
Compare
Firestar99
force-pushed
the
gsvg_renderer
branch
2 times, most recently
from
20c7be5 to
bb01fd9
Compare
Firestar99
force-pushed
the
extract_math_nodes
branch
from
5eaa7d9 to
4d4977e
Compare
TrueDoctor
reviewed
Jun 27, 2025
Comment on lines
+393
to
+416
| /// The logical or operation (||) returns true if either of the two inputs are true, or false if both are false. | ||
| #[node_macro::node(category("Math: Logic"))] | ||
| fn logical_or(_: impl Ctx, value: bool, other_value: bool) -> bool { | ||
| value || other_value | ||
| } | ||
|
|
||
| /// The logical and operation (&&) returns true if both of the two inputs are true, or false if any are false. | ||
| #[node_macro::node(category("Math: Logic"))] | ||
| fn logical_and(_: impl Ctx, value: bool, other_value: bool) -> bool { | ||
| value && other_value | ||
| } | ||
|
|
||
| /// The logical not operation (!) reverses true and false value of the input. | ||
| #[node_macro::node(category("Math: Logic"))] | ||
| fn logical_not(_: impl Ctx, input: bool) -> bool { | ||
| !input | ||
| } | ||
|
|
||
| /// Constructs a bool value which may be set to true or false. | ||
| #[node_macro::node(category("Value"))] | ||
| fn bool_value(_: impl Ctx, _primary: (), #[name("Bool")] bool_value: bool) -> bool { | ||
| bool_value | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
I'm wondering if it would make more sense to move these to the logic mod now that the mod is no longer called ops
Collaborator
Author
There was a problem hiding this comment.
We can split up the lib into smaller mods, though I'd create a new logic op and not put it into the old, since the old is almost exclusively string manipulation except for SwitchNode (which I may move here)
Member
There was a problem hiding this comment.
Alright, just wanted to make you aware of this, we can always move things later once we are a bit more settled into the new structure
TrueDoctor
approved these changes
Jun 27, 2025
Firestar99
force-pushed
the
extract_math_nodes
branch
from
4d4977e to
f3629ab
Compare
urisinger
pushed a commit
to urisinger/Graphite
that referenced
this pull request
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #2760
Split out from #2746 (comment)