Prep gcore splitup: move various symbols into their own modules
#2746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firestar99
force-pushed
the
move_gcore_symbols
branch
from
f86a055 to
0c0b723
Compare
Firestar99
force-pushed
the
move_gcore_symbols
branch
from
0c0b723 to
755c018
Compare
Firestar99
force-pushed
the
move_gcore_symbols
branch
from
1a3ea16 to
1bfc773
Compare
Firestar99
force-pushed
the
move_gcore_symbols
branch
from
1bfc773 to
23a3af7
Compare
Firestar99
force-pushed
the
move_gcore_symbols
branch
from
7b8e81f to
49c43c4
Compare
Keavon
changed the title
gcore symbolsgcore symbols into their own modules
Firestar99
force-pushed
the
move_gcore_symbols
branch
from
f6fae5b to
7c794a8
Compare
Firestar99
changed the title
gcore symbols into their own modulesgcore splitup: move various symbols into their own modules
TrueDoctor
reviewed
Jun 27, 2025
TrueDoctor
approved these changes
Jun 27, 2025
Firestar99
force-pushed
the
move_gcore_symbols
branch
from
7c794a8 to
be9f978
Compare
Firestar99
force-pushed
the
move_gcore_symbols
branch
from
be9f978 to
699fe42
Compare
Collaborator
Author
|
Removed commit "move nodes from This PR can be merged. |
urisinger
pushed a commit
to urisinger/Graphite
that referenced
this pull request
Jul 15, 2025
…aphiteEditor#2746) * move `trait AsU32` from `gcore::vector::misc` to `gcore` * move blending and gradient to their own modules * fix unused warnings * move `Quad`, `Rect` and `BBox` to `gcore::math` * extract `ReferencePoint` and transform nodes from `transform` * move color-related code to `mod color` * fix unused warning in test code * move blending-related nodes and code to `mod blending_nodes` * move ClickTarget code to `mod vector::click_target`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving some symbols within
gcoreto their own modules, to allow them to remain withingcoreand move the rest into separate crates in a later PR.