Skip to content

Add error if env var is not set #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
averikitsch merged 3 commits into from
Jan 26, 2021
Merged

Add error if env var is not set #716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
13b1349
Add error if env var is not set
averikitsch Dec 9, 2020
c0743db
Update bundle version
averikitsch Jan 5, 2021
2e8853a
downgrade dockerfile version
averikitsch Jan 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion run/helloworld/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

# Use the official lightweight Ruby image.
# https://hub.docker.com/_/ruby
FROM ruby:2.7-slim
FROM ruby:2.5-slim

# Install production dependencies.
WORKDIR /usr/src/app
Expand Down
2 changes: 1 addition & 1 deletion run/helloworld/Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,4 +62,4 @@ DEPENDENCIES
sinatra (~> 2.0)

BUNDLED WITH
2.1.4
1.17.3
11 changes: 8 additions & 3 deletions run/helloworld/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,14 @@ docker run --rm -p 9090:8080 -e PORT=8080 helloworld:ruby

## Test

```
```sh
# Set an environment variable with your GCP Project ID
export GOOGLE_CLOUD_PROJECT=<PROJECT_ID>

# Install dependencies
bundle install

# Run tests
bundle exec rspec
```

Expand All @@ -46,8 +52,7 @@ export GOOGLE_CLOUD_PROJECT=<PROJECT_ID>
gcloud builds submit --tag gcr.io/${GOOGLE_CLOUD_PROJECT}/helloworld

# Deploy to Cloud Run
gcloud run deploy helloworld \
--image gcr.io/${GOOGLE_CLOUD_PROJECT}/helloworld
gcloud run deploy helloworld --image gcr.io/${GOOGLE_CLOUD_PROJECT}/helloworld
```

Visit your deployed container by opening the service URL in a web browser.
3 changes: 3 additions & 0 deletions run/helloworld/spec/e2e_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@

describe "E2E tests" do
before (:all) do
if !ENV["GOOGLE_CLOUD_PROJECT"]
raise "GOOGLE_CLOUD_PROJECT env var not found."
end
suffix = SecureRandom.hex(15)
system("gcloud",
"builds",
Expand Down