Skip to content

Conversation

@averikitsch
Copy link
Contributor

@averikitsch averikitsch commented Dec 9, 2020

Description

Fixes #646

Note: It's a good idea to open an issue first for discussion.

Checklist

  • Tests pass
  • Lint pass: bundle exec rubocop
  • Please merge this PR for me once it is approved.

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Dec 9, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 9, 2020
@averikitsch averikitsch added the automerge Merge the pull request once unit tests and other checks pass. label Dec 9, 2020
@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 9, 2020
@averikitsch averikitsch added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 10, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 10, 2020
Copy link
Contributor

@TheRoyalTnetennba TheRoyalTnetennba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you change

to 1.17.3

@averikitsch
Copy link
Contributor Author

@TheRoyalTnetennba tests are passing now. Thanks!

@averikitsch averikitsch added the automerge Merge the pull request once unit tests and other checks pass. label Jan 5, 2021
@averikitsch
Copy link
Contributor Author

@GoogleCloudPlatform/yoshi-ruby please review

@averikitsch averikitsch merged commit a77f58a into master Jan 26, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 26, 2021
@averikitsch averikitsch deleted the run-fix branch January 26, 2021 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

run/ GOOGLE_CLOUD_PROJECT required for running tests

3 participants