-
Notifications
You must be signed in to change notification settings - Fork 6.7k
fix: use same project for all testing #9491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
6c95225
2d78d0b
0503aec
4a1270e
e0dfa56
d9327b2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,8 +30,8 @@ | |
| # to 'BUILD_SPECIFIC_GCLOUD_PROJECT' if you want to opt in using a | ||
| # build specific Cloud project. You can also use your own string | ||
| # to use your own Cloud project. | ||
| # "gcloud_project_env": "GOOGLE_CLOUD_PROJECT", | ||
| "gcloud_project_env": "BUILD_SPECIFIC_GCLOUD_PROJECT", | ||
| "gcloud_project_env": "GOOGLE_CLOUD_PROJECT", | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe that this is build specific for the VM quota issue as well - dataproc instances count towards the VM quota |
||
| # "gcloud_project_env": "BUILD_SPECIFIC_GCLOUD_PROJECT", | ||
| # A dictionary you want to inject into your test. Don't put any | ||
| # secrets here. These values will override predefined values. | ||
| "envs": {}, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,8 +30,8 @@ | |
| # to 'BUILD_SPECIFIC_GCLOUD_PROJECT' if you want to opt in using a | ||
| # build specific Cloud project. You can also use your own string | ||
| # to use your own Cloud project. | ||
| # "gcloud_project_env": "GOOGLE_CLOUD_PROJECT", | ||
| "gcloud_project_env": "BUILD_SPECIFIC_GCLOUD_PROJECT", | ||
| "gcloud_project_env": "GOOGLE_CLOUD_PROJECT", | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe that this is build specific for the VM quota issue as well - dataproc instances count towards the VM quota |
||
| # "gcloud_project_env": "BUILD_SPECIFIC_GCLOUD_PROJECT", | ||
| # If you need to use a specific version of pip, | ||
| # change pip_version_override to the string representation | ||
| # of the version number, for example, "20.2.4" | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,8 +30,8 @@ | |
| # to 'BUILD_SPECIFIC_GCLOUD_PROJECT' if you want to opt in using a | ||
| # build specific Cloud project. You can also use your own string | ||
| # to use your own Cloud project. | ||
| # "gcloud_project_env": "GOOGLE_CLOUD_PROJECT", | ||
| "gcloud_project_env": "BUILD_SPECIFIC_GCLOUD_PROJECT", | ||
| "gcloud_project_env": "GOOGLE_CLOUD_PROJECT", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change, combined with #9489 and upgrading python-docs-samples-tests to Enterprise, should permanently resolve the Dialogflow-related error |
||
| # "gcloud_project_env": "BUILD_SPECIFIC_GCLOUD_PROJECT", | ||
| # A dictionary you want to inject into your test. Don't put any | ||
| # secrets here. These values will override predefined values. | ||
| "envs": {}, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that this is build specific for the VM quota issue as well - dataproc instances count towards the VM quota