-
Notifications
You must be signed in to change notification settings - Fork 6.7k
fix: use same project for all testing #9491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| # to use your own Cloud project. | ||
| # "gcloud_project_env": "GOOGLE_CLOUD_PROJECT", | ||
| "gcloud_project_env": "BUILD_SPECIFIC_GCLOUD_PROJECT", | ||
| "gcloud_project_env": "GOOGLE_CLOUD_PROJECT", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change, combined with #9489 and upgrading python-docs-samples-tests to Enterprise, should permanently resolve the Dialogflow-related error
m-strzelczyk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm worried that we might face some new problems after squeezing all the tests into single project. Things like quota or tests interfering with each other.
I assume you have good reasons to change this for the samples you're investigating, so no veto from me in general. I'd only want to keep Batch tests in separate projects, as explained in my comment there.
| # to use your own Cloud project. | ||
| # "gcloud_project_env": "GOOGLE_CLOUD_PROJECT", | ||
| "gcloud_project_env": "BUILD_SPECIFIC_GCLOUD_PROJECT", | ||
| "gcloud_project_env": "GOOGLE_CLOUD_PROJECT", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that this is build specific for the VM quota issue as well - dataproc instances count towards the VM quota
| # to use your own Cloud project. | ||
| # "gcloud_project_env": "GOOGLE_CLOUD_PROJECT", | ||
| "gcloud_project_env": "BUILD_SPECIFIC_GCLOUD_PROJECT", | ||
| "gcloud_project_env": "GOOGLE_CLOUD_PROJECT", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that this is build specific for the VM quota issue as well - dataproc instances count towards the VM quota
| # to use your own Cloud project. | ||
| # "gcloud_project_env": "GOOGLE_CLOUD_PROJECT", | ||
| "gcloud_project_env": "BUILD_SPECIFIC_GCLOUD_PROJECT", | ||
| "gcloud_project_env": "GOOGLE_CLOUD_PROJECT", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that this is build specific for the VM quota issue as well - dataproc instances count towards the VM quota
|
Small variations between the different test projects have led to a lot of very hard to debug flaky errors. Using a single project will eliminate that problem, while making quota problems more likely. We have managed to resolve most of those problems (future PRs will be coming soon after this one is merged), except for:
|
Description
Does not use different projects for different versions of Python any more.