Skip to content

Add GitConfig::from_env_paths with git-like sequence resolution #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2021
Merged

Add GitConfig::from_env_paths with git-like sequence resolution #240

merged 1 commit into from
Nov 19, 2021

Conversation

caspervonb
Copy link
Contributor

@caspervonb caspervonb commented Oct 25, 2021 •
edited
Loading

Towards #191

@caspervonb caspervonb force-pushed the feat-git-config-known-paths branch from c2c9fdd to 3bc1d63 Compare October 25, 2021 09:50
@caspervonb caspervonb changed the title Add GitConfig::from_env_paths with git-like sequence resolution Add GitConfig::from_env_paths with git-like sequence resolution Oct 25, 2021
@caspervonb
Copy link
Contributor Author

caspervonb commented Oct 25, 2021 •
edited
Loading

This has no test coverage right now 😱
Pushed early on @Byron's request.
Bit busy in the coming days, I'll try to follow up with some basic coverage at-least.

@Byron
Copy link
Member

Byron commented Nov 19, 2021

Thanks a lot for your contribution!

I think it's OK to merge without tests given git-config is still unstable and that nobody is using this method yet.

@Byron Byron merged commit aec51a2 into GitoxideLabs:main Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caspervonb @Byron