-
-
Notifications
You must be signed in to change notification settings - Fork 346
git-config towards 1.0 #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
First thoughts; knocking out some tests and the features before even thinking about refactoring or breaking anything but I think we should would avoid doing any magical deref here. Parser itself is solid and pretty nice as-is, but it would be nice if we had a more user friendly serde-json like Value structure after parsing for Currently Raw pull parser, its items and events would still be available but am slightly leaning towards an easier to use abstraction on top of it. |
What would you suggest for a concrete implementation then? A separate type Ironically enough, serde compatibility was always a goal from the beginning but never achieved (yet) |
Not quite sure yet, but yes leaning a bit towards a separate variant type ala I'll probably sketch something out in a pull request soon. |
Following the conversation, I have trouble understanding how All I hope is that making these adjustments won't turn out to be an unexpectedly major undertaking. Please note that I am expressing my opinion based on non-neglectable ignorance about the actual implementation, so it might be missing the point as well. |
Just ergonomics and usability, parser features can be expanded upon just fine without touching or changing much. #[derive(Serialize, Deserialize)]
struct CoreSection {
// ...
}
#[derive(Serialize, Deserialize)]
struct Config {
core: Option<CoreSection>,
// ...
} |
A list of ideas for features that come up when using
git-config::file::GitConfig
Boolean
can act asbool
or be converted to one, maybe using derefInteger
derefs to integertry_value() -> Result<Option<T>, E>
as currently I am ignoring all errors as it's too cumbersome to check if the conversion failed which probably should be an actualMissing features
PathBuf
instead of just a stringRelated Discussions
The text was updated successfully, but these errors were encountered: