Skip to content

Feature/netcore3.0 #1849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 10, 2019
Merged

Feature/netcore3.0 #1849

merged 5 commits into from
Oct 10, 2019

Conversation

arturcic
Copy link
Member

@arturcic arturcic commented Oct 9, 2019 •
edited
Loading

This PR adds the following:

  • Added .net core 3.0 support
  • Drop .net core 2.2 support, we'll support current version (3.0) and lts version (2.1)
  • Made GitVersionCore target netstandard2.0
  • Generate SingleExecutable File for each os platform, for now the windows executable is used in the portable and cmdline package. Later we could add homebrew for macos as well as snaps https://snapcraft.io for linux. This will allow to run the GitVersion on macos and linux distros without mono or dotnet installed as it's self contained.
  • Drop ilmerge in favor of SingleExecutable
  • Publish tar.gz files, later on we'll add npm support using these tar.gz files

@arturcic arturcic requested a review from asbjornu October 9, 2019 18:26
@arturcic arturcic force-pushed the feature/netcore3.0 branch from 0543b60 to 1d6a9da Compare October 9, 2019 18:34
This was referenced Oct 10, 2019
Closed
Closed
@arturcic arturcic added this to the 5.1.0 milestone Oct 10, 2019
asbjornu
asbjornu approved these changes Oct 10, 2019
View reviewed changes
Copy link
Member

@asbjornu asbjornu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are absolutely amazing, @arturcic. ❤️

jetersen
jetersen approved these changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@jetersen jetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@arturcic
Copy link
Member Author

@asbjornu if you don't mind I'll merge the PR

@arturcic arturcic merged commit bc04fad into GitTools:master Oct 10, 2019
@arturcic arturcic deleted the feature/netcore3.0 branch October 10, 2019 11:03
@jetersen
Copy link
Contributor

Marvelous!

@nZeus nZeus mentioned this pull request Oct 10, 2019
Closed
This was referenced Oct 13, 2019
Closed
Closed
@Techcadia Techcadia mentioned this pull request Oct 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asbjornu asbjornu asbjornu approved these changes

@jetersen jetersen jetersen approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
5.1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@arturcic @jetersen @asbjornu