Skip to content

NuGet package for .NET Core 3.0 executables #1854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
matkoch opened this issue Oct 12, 2019 · 12 comments
Closed

NuGet package for .NET Core 3.0 executables #1854

matkoch opened this issue Oct 12, 2019 · 12 comments

Comments

@matkoch
Copy link
Contributor

matkoch commented Oct 12, 2019

More than often I'm lost when reading about new prerelease packages here, but unable to find belonging packages on nuget.org.

The issue about .NET Core 3.0 (It was not possible to find any compatible framework version) seems to have been addressed. Yet, which package contains the fix?

@asbjornu
Copy link
Member

asbjornu commented Oct 13, 2019

The problem might have been fixed in #1849. If you look at the latest commit in that PR and click the green checkmark ✔️ besides the commit ID, then click the AppVeyor build and go to its Artifacts, you'll find the build artifacts that correspond to the PR. From there you can download whichever variant of GitVersion you'd like.

You can also find the latest pre-release version published to NuGet.org with a release date newer than the merge date of the PR you want. Version 5.0.2-beta1.95 of GitVersion should therefore contain #1849.

@matkoch
Copy link
Contributor Author

matkoch commented Oct 13, 2019

@asbjornu
Copy link
Member

@arturcic, why aren't there any newer versions of GitVersion.CommandLine.DotNetCore than 5.0.2-beta1.71?

@arturcic
Copy link
Member

@asbjornu, that's because the global tool now can be installed as local tool as well, making the GitVersion.CommandLine.DotNetCore obsolete.

@arturcic
Copy link
Member

If you need the "exe" version you might need the GitVersion.CommandLine nuget package

@matkoch
Copy link
Contributor Author

matkoch commented Oct 15, 2019

No I don't, I just had the wrong package. It's a bit of a .... let's say I'm overwhelmed with possbilities.

The GitVersion.Tool package is 22mb. Sounds quite a lot for "just" calculating a version number. Is that really necessary?

@arturcic
Copy link
Member

The think is that we use a native library that has implementations for several linux distros as well as macOs and windows. All of them make the size bigger. The GitVersion itself is really small

@matkoch
Copy link
Contributor Author

matkoch commented Oct 15, 2019

times 2 for netcore2.1 and netcoreapp3.0

@arturcic
Copy link
Member

that is true, we'll need to think about reusing if possible the same native binaries

@gep13
Copy link
Member

gep13 commented Oct 15, 2019

@arturcic said...
that's because the global tool now can be installed as local tool as well, making the GitVersion.CommandLine.DotNetCore obsolete.

Would it make sense to mark it as such on nuget.org, now that NuGet.org has the ability to mark a package as deprecated?

As an example, have a look at the banner on this package:

https://www.nuget.org/packages/Cake.Tfs/

@arturcic
Copy link
Member

Unfortunately Gary I don't think I have access to the nuget.org. I have only the API_KEY. Can you help with that?

@gep13
Copy link
Member

gep13 commented Oct 15, 2019

@arturcic you should now have all the access that is required on NuGet.org. Let me know if there is anything else I can do to help.

@matkoch matkoch closed this as completed Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants