Improve handling of negative values for DMSAngles and DDMAngle classes #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…where degree is supplied as integer by introducing positive as a kwarg; create mod operators for DMSAngle and DDMAngle; update related dec2dms(), dec2ddm(), hp2dms(), hp2ddm() functions; update associated tests.
Upgrade python to current version (3.13) as 3.7 has reached end of life and is not supported with ubuntu-latest
revert to 3.11 for issues of code conventions which raise warnings in 3.13
…atting in test_convert.py; update array index for numpy deprecation warnings.
harry093
approved these changes
Feb 14, 2025
|
No worries, Craig! |
|
@nicgowans those changes have been included in GeodePy v0.6.0 and it has now been pushed to PyPI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily fixes an issue with
DMSAngleandDDMAngleclasses where negative values were lost when the degree term was an integer equal to 0. For example, if -0.0167 was provided todec2dms(), the returned value would be aDMSAngleinitialised with degree=-0, which is stored as 0 thus becoming positive.A method for the mod operator
%is also added for both classes.Additionally, there are a few changes which are outside the initial scope of this pull request but needed to be addressed due to failing CI workflows, including:
ubuntu-latest. Python 3.13 was adopted in its placetest_convert.pytransform.pydue to ambiguous indexing of arrays : DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ensure you extract a single element from your array before performing this operation. (Deprecated NumPy 1.25.)