-
Notifications
You must be signed in to change notification settings - Fork 228
Enable ruff's flake8-implicit-str-concat (ISC) rules #2837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Yvonne Fröhlich <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sofar I did not follow the PRs related to issue #2741 in greater detail. So, maybe I am missing some context here, but I am wondering why the ISC
rule is not added to the list in pyproject.toml
in contrast to the other ruff
rules:
Lines 100 to 112 in 78dfcf1
[tool.ruff.lint] | |
select = [ | |
"B", # flake8-bugbear | |
"E", # pycodestyle | |
"F", # pyflakes | |
"I", # isort | |
"NPY", # numpy | |
"PD", # pandas-vet | |
"PL", # pylint | |
"SIM", # flake8-simplify | |
"UP", # pyupgrade | |
"W", # pycodestyle warnings | |
] |
``` warning: The following rules may cause conflicts when used with the formatter: `ISC001`. To avoid unexpected behavior, we recommend disabling these rules, either by removing them from the `select` or `extend-select` configuration, or adding them to the `ignore` configuration. ```
Thanks for catching it. I forgot to add it. Now added in 0d78ee5 |
Co-authored-by: Michael Grund <[email protected]>
Description of proposed changes
Enable ISC rules.
Address #2741.
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version