Enable ruff's flake8-implicit-str-concat (ISC) rules (#2837)

* Enable ruff's flake8-implicit-str-concat (ISC) rules
* Update pygmt/clib/session.py
* Add ISC to pyproject.toml and ignore ISC001

Co-authored-by: Yvonne Fröhlich <[email protected]>
Co-authored-by: Michael Grund <[email protected]>

Author: 3 people

pygmt/clib/session.py

@@ -768,8 +768,7 @@ def _parse_constant(self, constant, valid, valid_modifiers=None):
             )
         if nmodifiers > 0 and valid_modifiers is None:
             raise GMTInvalidInput(
-                "Constant modifiers not allowed since valid values were not "
-                + f"given: '{constant}'"
+                "Constant modifiers are not allowed since valid values were not given: '{constant}'"
             )
         if name not in valid:
             raise GMTInvalidInput(

pygmt/helpers/utils.py

@@ -244,17 +244,17 @@ def non_ascii_to_octal(argstr):
             c: "@~\\" + format(i, "o") + "@~"
             for c, i in zip(
                 " !∀#∃%&∋()∗+,−./"  # \04x-05x
-                + "0123456789:;<=>?"  # \06x-07x
-                + "≅ΑΒΧΔΕΦΓΗΙϑΚΛΜΝΟ"  # \10x-11x
-                + "ΠΘΡΣΤΥςΩΞΨΖ[∴]⊥_"  # \12x-13x
-                + "αβχδεφγηιϕκλμνο"  # \14x-15x
-                + "πθρστυϖωξψζ{|}∼"  # \16x-17x. \177 is undefined
-                + "€ϒ′≤⁄∞ƒ♣♦♥♠↔←↑→↓"  # \24x-\25x
-                + "°±″≥×∝∂•÷≠≡≈…↵"  # \26x-27x
-                + "ℵℑℜ℘⊗⊕∅∩∪⊃⊇⊄⊂⊆∈∉"  # \30x-31x
-                + "∠∇®©™∏√⋅¬∧∨⇔⇐⇑⇒⇓"  # \32x-33x
-                + "◊〈®©™∑"  # \34x-35x
-                + "〉∫⌠⌡",  # \36x-37x. \360 and \377 are undefined
+                "0123456789:;<=>?"  # \06x-07x
+                "≅ΑΒΧΔΕΦΓΗΙϑΚΛΜΝΟ"  # \10x-11x
+                "ΠΘΡΣΤΥςΩΞΨΖ[∴]⊥_"  # \12x-13x
+                "αβχδεφγηιϕκλμνο"  # \14x-15x
+                "πθρστυϖωξψζ{|}∼"  # \16x-17x. \177 is undefined
+                "€ϒ′≤⁄∞ƒ♣♦♥♠↔←↑→↓"  # \24x-\25x
+                "°±″≥×∝∂•÷≠≡≈…↵"  # \26x-27x
+                "ℵℑℜ℘⊗⊕∅∩∪⊃⊇⊄⊂⊆∈∉"  # \30x-31x
+                "∠∇®©™∏√⋅¬∧∨⇔⇐⇑⇒⇓"  # \32x-33x
+                "◊〈®©™∑"  # \34x-35x
+                "〉∫⌠⌡",  # \36x-37x. \360 and \377 are undefined
                 [*range(32, 127), *range(160, 240), *range(241, 255)],
             )
         }
@@ -269,17 +269,17 @@ def non_ascii_to_octal(argstr):
             c: "@%34%\\" + format(i, "o") + "@%%"
             for c, i in zip(
                 " ✁✂✃✄☎✆✇✈✉☛☞✌✍✎✏"  # \04x-\05x
-                + "✐✑✒✓✔✕✖✗✘✙✚✛✜✝✞✟"  # \06x-\07x
-                + "✠✡✢✣✤✥✦✧★✩✪✫✬✭✮✯"  # \10x-\11x
-                + "✰✱✲✳✴✵✶✷✸✹✺✻✼✽✾✿"  # \12x-\13x
-                + "❀❁❂❃❄❅❆❇❈❉❊❋●❍■❏"  # \14x-\15x
-                + "❐❑❒▲▼◆❖◗❘❙❚❛❜❝❞"  # \16x-\17x. \177 is undefined
-                + "❡❢❣❤❥❦❧♣♦♥♠①②③④"  # \24x-\25x. \240 is undefined
-                + "⑤⑥⑦⑧⑨⑩❶❷❸❹❺❻❼❽❾❿"  # \26x-\27x
-                + "➀➁➂➃➄➅➆➇➈➉➊➋➌➍➎➏"  # \30x-\31x
-                + "➐➑➒➓➔→↔↕➘➙➚➛➜➝➞➟"  # \32x-\33x
-                + "➠➡➢➣➤➥➦➧➨➩➪➫➬➭➮➯"  # \34x-\35x
-                + "➱➲➳➴➵➶➷➸➹➺➻➼➽➾",  # \36x-\37x. \360 and \377 are undefined
+                "✐✑✒✓✔✕✖✗✘✙✚✛✜✝✞✟"  # \06x-\07x
+                "✠✡✢✣✤✥✦✧★✩✪✫✬✭✮✯"  # \10x-\11x
+                "✰✱✲✳✴✵✶✷✸✹✺✻✼✽✾✿"  # \12x-\13x
+                "❀❁❂❃❄❅❆❇❈❉❊❋●❍■❏"  # \14x-\15x
+                "❐❑❒▲▼◆❖◗❘❙❚❛❜❝❞"  # \16x-\17x. \177 is undefined
+                "❡❢❣❤❥❦❧♣♦♥♠①②③④"  # \24x-\25x. \240 is undefined
+                "⑤⑥⑦⑧⑨⑩❶❷❸❹❺❻❼❽❾❿"  # \26x-\27x
+                "➀➁➂➃➄➅➆➇➈➉➊➋➌➍➎➏"  # \30x-\31x
+                "➐➑➒➓➔→↔↕➘➙➚➛➜➝➞➟"  # \32x-\33x
+                "➠➡➢➣➤➥➦➧➨➩➪➫➬➭➮➯"  # \34x-\35x
+                "➱➲➳➴➵➶➷➸➹➺➻➼➽➾",  # \36x-\37x. \360 and \377 are undefined
                 [*range(32, 127), *range(161, 240), *range(241, 255)],
             )
         }
@@ -295,9 +295,9 @@ def non_ascii_to_octal(argstr):
             c: "\\" + format(i, "o")
             for c, i in zip(
                 "•…™—–fiž"  # \03x. \030 is undefined
-                + "š"  # \177
-                + "Œ†‡Ł⁄‹Š›œŸŽł‰„“”"  # \20x-\21x
-                + "ı`´ˆ˜¯˘˙¨‚˚¸'˝˛ˇ",  # \22x-\23x
+                "š"  # \177
+                "Œ†‡Ł⁄‹Š›œŸŽł‰„“”"  # \20x-\21x
+                "ı`´ˆ˜¯˘˙¨‚˚¸'˝˛ˇ",  # \22x-\23x
                 [*range(25, 32), *range(127, 160)],
             )
         }

pyproject.toml

@@ -104,6 +104,7 @@ select = [
     "F",    # pyflakes
     "FLY",  # flynt
     "I",    # isort
+    "ISC",  # flake8-implicit-str-concat
     "NPY",  # numpy
     "PD",   # pandas-vet
     "PL",   # pylint
@@ -113,6 +114,7 @@ select = [
 ]
 ignore = [
     "E501", # Avoid enforcing line-length violations
+    "ISC001", # Single-line-implicit-string-concatenation, conflict with formatter
     "PD901",  # Allow using the generic variable name `df` for DataFrames
     "PLR2004",  # Allow any magic values
     "SIM117",  # Allow nested `with` statements