Skip to content

feat: improve and update of geos-mesh utils functions #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 34 commits into from
Aug 6, 2025
Merged

feat: improve and update of geos-mesh utils functions #109

merged 34 commits into from
Aug 6, 2025

Conversation

RomainBaville
Copy link
Contributor

@RomainBaville RomainBaville commented Jun 27, 2025 •
edited by paloma-martinez
Loading

This PR updates the utils functions of geos-mesh:

  • Functions are added to arrayHelper.py
  • Functions in arrayModifiers are updated to be more global and consistent
    • VTK data type and value type are checked to be coherent
    • No more hard coded variable
  • Tests in test_arrayModifiers.py are updated to check more unit case

close #108

@RomainBaville RomainBaville self-assigned this Jun 27, 2025
@RomainBaville RomainBaville mentioned this pull request Jun 27, 2025
Open
paloma-martinez
paloma-martinez requested changes Jul 11, 2025
View reviewed changes
paloma-martinez
paloma-martinez approved these changes Jul 25, 2025
View reviewed changes
Copy link
Contributor

@paloma-martinez paloma-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work on the logger !

It looks good to me, I only made a few suggestions on wording

alexbenedicto
alexbenedicto reviewed Jul 30, 2025
View reviewed changes
@RomainBaville RomainBaville mentioned this pull request Aug 6, 2025
Open
@alexbenedicto alexbenedicto merged commit 02f9aa2 into main Aug 6, 2025
43 checks passed
@alexbenedicto alexbenedicto deleted the RomainBaville/feature/update_geos-mesh_utils branch August 6, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paloma-martinez paloma-martinez paloma-martinez approved these changes

@alexbenedicto alexbenedicto alexbenedicto approved these changes

Assignees

@RomainBaville RomainBaville

Labels
flag: ready for review type: cleanup type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve geos-mesh utils functions
3 participants
@RomainBaville @paloma-martinez @alexbenedicto