feat: add FillPartialArrays vtk filter and paraview plugin #105
+451
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…artialattribute, it is still nan by default
…utes in the fillallpartialattributes function
…ckdataset if it exist
Co-authored-by: paloma-martinez <[email protected]>
Update to last version of the main
…artialArray Uptade to last version of the main
RomainBaville
changed the base branch from
main
to
RomainBaville/feature/update_geos-mesh_utils
Base automatically changed from
RomainBaville/feature/update_geos-mesh_utils
to
main
August 6, 2025 18:24
paloma-martinez
approved these changes
Aug 8, 2025
| assert ( npArrayFilled == npArrayTest ).all() | ||
|
|
||
| vtkDataTypeFilled: int = attributeFilled.GetDataType() | ||
| assert vtkDataTypeTest == vtkDataTypeFilled |
There was a problem hiding this comment.
Suggested change
| assert vtkDataTypeTest == vtkDataTypeFilled | |
| assert vtkDataTypeFilled == vtkDataTypeTest |
| </StringVectorProperty> | ||
| """ ) | ||
| def _setDictAttributesValues( self: Self, attributeName: str, values: str ) -> None: | ||
| """Set the the dictionary with the region indexes and its corresponding list of value for each components. |
There was a problem hiding this comment.
Suggested change
| """Set the the dictionary with the region indexes and its corresponding list of value for each components. | |
| """Set the dictionary with the region indexes and its corresponding list of value for each components. |
|
|
||
| Args: | ||
| value (str): Input | ||
| attributeName (str): Name of the attribute to consider. | ||
| values (str): List of the filing values. If multiple components use a coma between the value of each component. |
There was a problem hiding this comment.
Suggested change
| values (str): List of the filing values. If multiple components use a coma between the value of each component. | |
| values (str): List of the filing values. If multiple components use a comma between the value of each component. |
Comment on lines
+103
to
+106
| if attributeName is not None and values is not None : | ||
| self.dictAttributesValues[ attributeName ] = list( values.split( "," ) ) | ||
| elif attributeName is not None and values is None: | ||
| self.dictAttributesValues[ attributeName ] = None |
There was a problem hiding this comment.
Suggested change
| if attributeName is not None and values is not None : | |
| self.dictAttributesValues[ attributeName ] = list( values.split( "," ) ) | |
| elif attributeName is not None and values is None: | |
| self.dictAttributesValues[ attributeName ] = None | |
| if attributeName is not None: | |
| if values is not None : | |
| self.dictAttributesValues[ attributeName ] = list( values.split( "," ) ) | |
| else: | |
| self.dictAttributesValues[ attributeName ] = None |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the possibility to fill a partial arrays with values
close #104