Added subscriber options to HttpCache

[lolautruche]

Based on #177, ref #170

This PR adds 2 options that one can add in their getOptions():

• fos_native_subscribers: bit options to activate/deactivate subscribers provided by FOSHttpCacheBundle

  By default all native subscribers are activated (HttpCache::SUBSCRIBER_ALL).

Examples with fos_native_subscribers

ALL native subscribers EXCEPT the user context one

protected function getOptions()
{
    return [
        'fos_native_subscribers' => self::SUBSCRIBER_ALL | ~self::SUBSCRIBER_USER_CONTEXT
    ]
}

NO native subscribers

protected function getOptions()
{
    return [
        'fos_native_subscribers' => self::SUBSCRIBER_NONE
    ]
}

ONLY user context subscribers

protected function getOptions()
{
    return [
        'fos_native_subscribers' => self::SUBSCRIBER_USER_CONTEXT
    ]
}

User context subscriber AND Foo subscriber

protected function getOptions()
{
    return [
        'fos_native_subscribers' => self::SUBSCRIBER_USER_CONTEXT | self::SUBSCRIBER_FOO
    ]
}

[stof]

does it need to be public ?

[lolautruche]

No. Did it for testing purpose, but I could use Reflection in the test.

[stof]

Use Reflection then. Turning a private method into a public one just for testing purpose is bad, because public methods are affected by BC while private are not.

[dbu]

thanks, looks good. i will add your PR doc into the .rst doc, once we merged this. so we need to figure out the options / init question.

[lolautruche]

Hmmm, it seems that conflicts appeared suddenly... Tell me when you're finished with modifications in your branch :-)

[lolautruche]

Rebased on your branch @dbu (solved conflicts that appeared after your last update).
So repeating my arguments on getOptions() vs constructor change:

• More elegant (IMHO).
• Easier to use.
• Doesn't need to modify the front controller.

[dbu]

i would prefer to remove this option and only keep the bitmap.

creating those subscribers should be done outside the kernel, or can be done in the constructor. there is no benefit in the indirection that i can see.

[dbu]

or the user can overwrite getSubscribers to add his own subscribers, instead of the constructor.

[lolautruche]

OK, I'll remove the option then. Documentation should state that one can add custom subscribers by overriding getSubscribers().

[dbu]

i updated my branch from the feedback from stof. i will leave it alone now until this is merged, to avoid further conflicts :-)

can we "compromise" on using the options bitmap only for default subscribers, and leave it to the user to do custom subscribers in getSubscribers or the constructor, or the frontend controller?

[lolautruche]

@dbu Just updated 😄 . I removed the custom subscribers option.
Custom subscribers can then be added by overriding getSubscribers(), constructor or by editing the frontend controller 😃

I also fixed a fatal error due to namespace collision from your last refactoring in respect to feedback from @stof

[dbu]

great, thanks a lot! i merged it into my branch so that we can discuss in one place again :-)

[lolautruche]

So cool ! Thanks for merging 👍

[dbu]

thanks for the contribution!