Adding support for user context for symfony HttpCache

[dbu]

Moving most of FriendsOfSymfony/FOSHttpCacheBundle#177 to the library.

• Documentation (see also Added subscriber options to HttpCache FOSHttpCacheBundle#178 but note that things changed since then)

[dbu]

I keep this kernel very minimal. The component kernel does not define the getOptions method anyways. And i guess people using the component directly are used to hand-craft their things.

[stof]

I would call it EventDispatchingHttpCache rather than just HttpCache, to make the name explicit about the difference to the parent class

[dbu]

should we do the same in the bundle?

[dbu]

okay, tests are green again.

last round of feedback @lolautruche @ddeboer ?

[lolautruche]

Wrong order.
Should be the following (opposite of array_merge())

$this->options = $options + array(
    'default' => 'value'
)

[dbu]

ouch, good catch

[stof]

this is the wrong order too

[stof]

btw, why merging the default yourselves ? you should test passing incomplete options

[dbu]

the order here is correct. i want some test headers.

the reason to merge is so that i can do the right headers in the tests below. i guess i have to split the two.

[ddeboer]

Looks great to me. However, docs are still missing. @dbu Can you add doc changes to this PR? We probably need:

• a chapter under ‘Caching Proxy Configuration’; we should just consider the Symfony Cache as a proxy alongside Varnish and Nginx, right? Move http://foshttpcachebundle.readthedocs.org/en/latest/features/symfony-http-cache.html here and then reference it from the bundle docs?
• add ‘Symfony Cache’ to built-in support in README.md

[dbu]

alright, i just added a bunch of documentation.

[dbu]

fixed the doc to not have a duplicated reference label.

fine like this? anything we need to do or can we merge?

[ddeboer]

‘component’ is a bit misleading, as HttpCache is no Symfony Component. Better: ‘Symfony Reverse Proxy’.

[dbu]

hm. "Symfony Reverse Proxy from the http-kernel component"? i want to point out that its about a component ,and not the symfony framework.

[ddeboer]

Thanks @dbu and @lolautruche. Added comments about some minor details. Let’s fix them and merge this! 😄

[dbu]

thanks, updated