Skip to content

Revert Portable/MikroC Formatting #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 23, 2023
Merged

Conversation

Skptak
Copy link
Member

@Skptak Skptak commented Nov 8, 2023

Description

Revert PR #768 on MikroC ports

Test Steps

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Skptak Skptak requested a review from a team as a code owner November 8, 2023 23:01
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@a8a17dc). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #882   +/-   ##
=======================================
  Coverage        ?   93.67%           
=======================================
  Files           ?        6           
  Lines           ?     3177           
  Branches        ?      884           
=======================================
  Hits            ?     2976           
  Misses          ?       94           
  Partials        ?      107           
Flag Coverage Δ
unittests 93.67% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Skptak Skptak mentioned this pull request Nov 8, 2023
2 tasks
@htibosch
Copy link

htibosch commented Nov 9, 2023

Hello @Skptak, if it doesn't take too much effort, it would be great if you can explain the reasons why you are creating this PR and other recent PRs.

People like me are wasting time opening the page "File changed" in order to discover if anything essential was changed.

It looks like you're raising a series of PR's that are reverting changes. But please put a link or copy/paste a short text.

@Skptak
Copy link
Member Author

Skptak commented Nov 10, 2023

Hello @Skptak, if it doesn't take too much effort, it would be great if you can explain the reasons why you are creating this PR and other recent PRs.

People like me are wasting time opening the page "File changed" in order to discover if anything essential was changed.

It looks like you're raising a series of PR's that are reverting changes. But please put a link or copy/paste a short text.

Hey @htibosch ,this set of PRs for reverting #768 is being done as we cannot determine if the whitespace changes made in the port files cause compilation errors or not. As we cannot determine if these are breaking changes or not the decision was mde to simply revert all formatting changes in the portable directory.

@htibosch
Copy link

Hey @htibosch ,this set of PRs for reverting #768 is being done as we cannot determine if the whitespace changes made in the port files cause compilation errors or not. As we cannot determine if these are breaking changes or not the decision was mde to simply revert all formatting changes in the portable directory.

Ok, thank you for the clear explanation :-)

Copy link
Member

@chinglee-iot chinglee-iot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared with commit before #768
d6bccb1 | 2023-09-05 | Gaurav-Aggarwal-AWS | Fix heap address calculation issue (#781)

d6bccb1...Skptak:FreeRTOS-Kernel:fixMikroCFormatting

  • portable/MikroC/ARM_CM4F/port.c :
    more trace macro are added in future commits
  • portable/MikroC/ARM_CM4F/portmacro.h :
    more trace macro are added in future commits

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aggarg aggarg merged commit 2dfc514 into FreeRTOS:main Nov 23, 2023
@Skptak Skptak deleted the fixMikroCFormatting branch December 19, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants