-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Revert Portable/MikroC Formatting #882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #882 +/- ##
=======================================
Coverage ? 93.67%
=======================================
Files ? 6
Lines ? 3177
Branches ? 884
=======================================
Hits ? 2976
Misses ? 94
Partials ? 107
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hello @Skptak, if it doesn't take too much effort, it would be great if you can explain the reasons why you are creating this PR and other recent PRs. People like me are wasting time opening the page "File changed" in order to discover if anything essential was changed. It looks like you're raising a series of PR's that are reverting changes. But please put a link or copy/paste a short text. |
Hey @htibosch ,this set of PRs for reverting #768 is being done as we cannot determine if the whitespace changes made in the port files cause compilation errors or not. As we cannot determine if these are breaking changes or not the decision was mde to simply revert all formatting changes in the portable directory. |
Ok, thank you for the clear explanation :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compared with commit before #768
d6bccb1 | 2023-09-05 | Gaurav-Aggarwal-AWS | Fix heap address calculation issue (#781)
d6bccb1...Skptak:FreeRTOS-Kernel:fixMikroCFormatting
- portable/MikroC/ARM_CM4F/port.c :
more trace macro are added in future commits - portable/MikroC/ARM_CM4F/portmacro.h :
more trace macro are added in future commits
Kudos, SonarCloud Quality Gate passed!
|
Description
Revert PR #768 on MikroC ports
Test Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.