-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix heap address calculation issue #781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was introduced in PR 771. Signed-off-by: Gaurav Aggarwal <[email protected]>
This was referenced Sep 5, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #781 +/- ##
=======================================
Coverage 94.35% 94.35%
=======================================
Files 6 6
Lines 2446 2446
Branches 598 598
=======================================
Hits 2308 2308
Misses 85 85
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kar-rahul-aws
approved these changes
Sep 5, 2023
n9wxu
approved these changes
Sep 5, 2023
Ran the FreeRTOS-Plus-TCP tests as mentioned in #778 and validated they pass with these changes:
|
This was referenced Nov 21, 2023
This was referenced Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This heap calculation issue was introduced in PR 771.
Test Steps
Before - Malloc failed hook fires on first invocation of pvPortMalloc.
After - pvPortMalloc works as expected.
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.