Skip to content

Conversation

@emyller
Copy link
Contributor

@emyller emyller commented Dec 3, 2025

Complete the transition to the context-based evaluation engine by removing the old FeatureStateModel-based engine code.

This is PR 3/3 in the series:

  1. feat(Engine): Evaluate from EvaluationContext #108
  2. feat(Local evaluation): Use the new context-based engine #109
  3. feat(Engine)!: Use context-based evaluation engine #126 (this PR)

Changes

  • Remove old Engine static methods that operate on FeatureStateModel
  • Remove SegmentEvaluator and related segment evaluation classes
  • Remove unused Flag and Flags factory methods
  • Remove dead test files for old engine functionality

Warning

This is a breaking change. Users who directly call removed methods or classes will experience runtime errors after upgrading.

Contributes to #122

Review effort: 2/5

@emyller emyller requested a review from a team as a code owner December 3, 2025 21:31
@emyller emyller requested review from gagantrivedi and removed request for a team December 3, 2025 21:31
@emyller emyller self-assigned this Dec 3, 2025
Copy link
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My favourite kind of pull request.

@emyller emyller merged commit 91b0a3b into main Dec 4, 2025
19 checks passed
@emyller emyller deleted the refactor/engine/remove-old-engine branch December 4, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants