feat(Local evaluation): Use the new context-based engine #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributes to Flagsmith/flagsmith#6121
emyller
changed the title
emyller
commented
Oct 4, 2025
khvn26
reviewed
Oct 15, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
khvn26
reviewed
Oct 16, 2025
khvn26
requested changes
Oct 16, 2025
Member
khvn26
left a comment
khvn26
left a comment
There was a problem hiding this comment.
Sorry, one more comment from me to address.
emyller
force-pushed
the
feat/context-values-client
branch
from
c5015d7 to
a75e860
Compare
gagantrivedi
approved these changes
Oct 20, 2025
Member
|
Created #111 to address @gagantrivedi's comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #98
This is pass 2 of 3.
get_evaluation_result+ engine tests passing. No deleted code. (PR)Warning
CANNOT MERGE before #108 (pass 1).
The client work is largely inspired by flagsmith-python-client.