Skip to content

feat: Add FeatureValue.variants[].priority sorting tests #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khvn26 merged 5 commits into from
Oct 15, 2025
+102 −0
Merged

feat: Add FeatureValue.variants[].priority sorting tests #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f3784c8
feat: Add `FeatureValue.variants[].priority` sorting tests
khvn26 Oct 14, 2025
cb9e084
add comments
khvn26 Oct 14, 2025
429c192
Apply suggestions from code review
khvn26 Oct 14, 2025
c1cf82e
use 50/50 splits
khvn26 Oct 14, 2025
aca26aa
improve docs
khvn26 Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions test_cases/test_multivariate__option_a_stronger_priority__expected_flags.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
{
// Given: A multivariate feature with two variants of equal weight, where option_b has a stronger priority (lower priority number)
// and an identity resulting in 49.27% percentage allocation
// When: Evaluating the feature for the given identity
// Then: The variant with stronger priority (option_a) should be selected as the feature value
"$schema": "https://raw.githubusercontent.com/Flagsmith/engine-test-data/refs/tags/v2.0.0/schema.json",
"context": {
"environment": {
"key": "test_env",
"name": "Test Environment"
},
"identity": {
"identifier": "0cfd0d72-4de4-4ed7-9cfb-d80dc3dacead",
"key": "32103813"
},
"features": {
"multivariate_feature": {
"enabled": true,
"feature_key": "15062",
"key": "78986",
"name": "multivariate_feature",
"value": "foo",
"variants": [
{
"value": "option_a",
"weight": 50,
"priority": 10
},
{
"value": "option_b",
"weight": 50,
"priority": 20
}
]
}
},
"segments": {}
},
"result": {
"flags": {
"multivariate_feature": {
"enabled": true,
"feature_key": "15062",
"name": "multivariate_feature",
"reason": "SPLIT; weight=50",
"value": "option_a"
}
},
"segments": []
}
}
51 changes: 51 additions & 0 deletions test_cases/test_multivariate__option_b_stronger_priority__expected_flags.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
{
// Given: A multivariate feature with two variants of equal weight, where option_b has a stronger priority (lower priority number)
// and an identity resulting in 49.27% percentage allocation
// When: Evaluating the feature for the given identity
// Then: The variant with stronger priority (option_b) should be selected as the feature value
"$schema": "https://raw.githubusercontent.com/Flagsmith/engine-test-data/refs/tags/v2.0.0/schema.json",
"context": {
"environment": {
"key": "test_env",
"name": "Test Environment"
},
"identity": {
"identifier": "0cfd0d72-4de4-4ed7-9cfb-d80dc3dacead",
"key": "32103813"
},
"features": {
"multivariate_feature": {
"enabled": true,
"feature_key": "15062",
"key": "78986",
"name": "multivariate_feature",
"value": "foo",
"variants": [
{
"value": "option_a",
"weight": 50,
"priority": 20
},
{
"value": "option_b",
"weight": 50,
"priority": 10
}
]
}
},
"segments": {}
},
"result": {
"flags": {
"multivariate_feature": {
"enabled": true,
"feature_key": "15062",
"name": "multivariate_feature",
"reason": "SPLIT; weight=50",
"value": "option_b"
}
},
"segments": []
}
}