feat: Add FeatureValue.variants[].priority sorting tests
#28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zaimwa9
requested changes
Oct 14, 2025
test_cases/test_multivariate__option_a_stronger_priority__expected_flags.jsonc
Outdated
Show resolved
Hide resolved
test_cases/test_multivariate__option_b_stronger_priority__expected_flags.jsonc
Outdated
Show resolved
Hide resolved
Zaimwa9
reviewed
Oct 14, 2025
test_cases/test_multivariate__option_b_stronger_priority__expected_flags.jsonc
Outdated
Show resolved
Hide resolved
test_cases/test_multivariate__option_b_stronger_priority__expected_flags.jsonc
Outdated
Show resolved
Hide resolved
test_cases/test_multivariate__option_b_stronger_priority__expected_flags.jsonc
Outdated
Show resolved
Hide resolved
test_cases/test_multivariate__option_a_stronger_priority__expected_flags.jsonc
Outdated
Show resolved
Hide resolved
test_cases/test_multivariate__option_a_stronger_priority__expected_flags.jsonc
Outdated
Show resolved
Hide resolved
test_cases/test_multivariate__option_a_stronger_priority__expected_flags.jsonc
Outdated
Show resolved
Hide resolved
khvn26
force-pushed
the
feat/variant-priority-sorting
branch
from
3c0f334 to
12a5e32
Compare
khvn26
force-pushed
the
feat/variant-priority-sorting
branch
from
0c1d891 to
aca26aa
Compare
Zaimwa9
reviewed
Oct 15, 2025
test_cases/test_multivariate__option_a_stronger_priority__expected_flags.jsonc
Show resolved
Hide resolved
Zaimwa9
approved these changes
Oct 15, 2025
Contributor
Zaimwa9
left a comment
Zaimwa9
left a comment
There was a problem hiding this comment.
Perfect, looks good to me, thanks for the effort
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we add test cases for sorting the multivariate variants by priority.