Skip to content

Fix up logging #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 24, 2025
Merged

Fix up logging #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
189fe80
fix up logging
aarsilv Oct 24, 2025
169ef68
next version
typotter Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ java {
}

group = 'cloud.eppo'
version = '5.3.1-SNAPSHOT'
version = '5.3.2'
ext.isReleaseVersion = !version.endsWith("SNAPSHOT")

import org.apache.tools.ant.filters.ReplaceTokens
Expand All @@ -36,10 +36,10 @@ dependencies {
implementation 'com.fasterxml.jackson.core:jackson-databind:2.19.0'
implementation 'org.ehcache:ehcache:3.10.8'
implementation 'org.slf4j:slf4j-api:2.0.17'
// Logback classic 1.3.x is compatible with java 8
implementation 'ch.qos.logback:logback-classic:1.3.15'
implementation 'org.jetbrains:annotations:26.0.2'

// Logback classic 1.3.x is compatible with java 8 - only needed for tests
testImplementation 'ch.qos.logback:logback-classic:1.3.15'
Copy link
Collaborator Author

@aarsilv aarsilv Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 core part of the fix: moving this to test implementation only

testImplementation 'cloud.eppo:sdk-common-jvm:3.5.4:tests'
testImplementation platform('org.junit:junit-bom:5.11.4')
testImplementation 'org.junit.jupiter:junit-jupiter'
Expand All @@ -56,6 +56,7 @@ test {
showExceptions true
showCauses true
showStackTraces true
showStandardStreams true
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/logback-test.xml → src/test/resources/logback-test.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
</encoder>
</appender>

<root level="INFO">
<root level="DEBUG">
Copy link
Collaborator Author

@aarsilv aarsilv Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While in this moved file, changed lowest log level to debug as that is handy with unit tests.

👇 Note other xml file also moved to src/test as well.

<appender-ref ref="STDOUT" />
</root>
</configuration>
0 src/main/resources/logback.xml → src/test/resources/logback.xml
View file
Open in desktop
File renamed without changes.