Fix up logging #140
Merged
Fix up logging #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarsilv
commented
Oct 24, 2025
| implementation 'org.jetbrains:annotations:26.0.2' | ||
|
|
||
| // Logback classic 1.3.x is compatible with java 8 - only needed for tests | ||
| testImplementation 'ch.qos.logback:logback-classic:1.3.15' |
Collaborator
Author
There was a problem hiding this comment.
🔧 core part of the fix: moving this to test implementation only
| </appender> | ||
|
|
||
| <root level="INFO"> | ||
| <root level="DEBUG"> |
Collaborator
Author
There was a problem hiding this comment.
While in this moved file, changed lowest log level to debug as that is handy with unit tests.
👇 Note other xml file also moved to src/test as well.
typotter
approved these changes
Oct 24, 2025
Collaborator
typotter
left a comment
typotter
left a comment
There was a problem hiding this comment.
looks good. version # just needs a bump since we already cut v3.5.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eppo Internal
//: # (Link to the issue or doc corresponding to this chunk of work)
🎟️ Ticket: FFESUPPORT-103 - Java SDK overrides local configuration
Motivation and Context
Logging is currently misconfigured. The artifact
cloud.eppo:eppo-server-sdk:5.0.0is including alogback.xmlwhich got picked up by Logbacks auto-configuration and was overwriting our configuration.Description
Move the logback xml files to be test resources. Also adjust test logging a bit
How has this been documented?
n/a - bug fix
How has this been tested?
Packaged a jar and made sure the logback xml files were not in the jar