NO-HF: Move block.proof.challenge to Consensus::Params::signblockscript #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
jtimon
force-pushed
the
e14-blocksign-no-hf
branch
from
c66621a to
8f4e98a
Compare
Since the scriptPubKey for signing blocks never changes, there's no point reading repeating it from every block header.
jtimon
force-pushed
the
e14-blocksign-no-hf
branch
from
8f4e98a to
710df6d
Compare
1 task
instagibbs
approved these changes
Jul 11, 2018
| result.push_back(Pair("signblock_asm", ScriptToAsmStr(pblock->proof.challenge))); | ||
| result.push_back(Pair("signblock_hex", HexStr(pblock->proof.challenge.begin(), pblock->proof.challenge.end()))); | ||
| result.push_back(Pair("signblock_asm", ScriptToAsmStr(consensusParams.signblockscript))); | ||
| result.push_back(Pair("signblock_hex", HexStr(consensusParams.signblockscript.begin(), consensusParams.signblockscript.end()))); |
Contributor
There was a problem hiding this comment.
nit: no need for the begin/end stuff, just do like https://github.com/ElementsProject/elements/pull/386/files#diff-a0c8f511d90e83aa9b5857e819ced344R1082
Contributor
|
ACK |
instagibbs
added a commit
that referenced
this pull request
Jul 11, 2018
…ignblockscript 710df6d NO-HF: Move block.proof.challenge to Consensus::Params::signblockscript (Jorge Timón)
delta1
pushed a commit
to delta1/elements
that referenced
this pull request
Apr 9, 2023
62b125f qt, refactor: Fix indentation (Prateek Sancheti) ad28b66 qt: Add SubFeeFromAmount option (Prateek Sancheti) Pull request description: This PR adds **_SubFeeFromAmount_** option which lets the user select their preferred setting of whether fee for a transaction is to be subtracted from the amount or not for future transactions. The setting chosen by the user is remembered even when the GUI mode is turned off. **_Functionality and Usage:_** - Go to `Settings > Options > Wallet` on _Windows/Linux_ or `bitcoin-qt > Preferences > Wallet` on _macOS_. - The checkbox **Subtract Fee From Amount** corresponds to the added option **SubFeeFromAmount**. - The preferred setting intended to be the default for all future send transactions should be selected by the user. - Click on **OK**. - Go to the **Send** tab in the wallet. - You shall notice, any new Send transaction created will have the preferred setting as chosen by the user.<br> (Try clicking on Add recipient or even restarting the Node in GUI) Attaching ScreenRecordings to explain the added feature. > Master.mov: Master Branch https://user-images.githubusercontent.com/54016434/127763378-be91837d-d0ab-4ae5-87c0-d303fa70a336.mov > PR.mov: PullRequest https://user-images.githubusercontent.com/54016434/127763404-05b834c1-4082-4fbd-9b05-1528ac898a21.mov Close ElementsProject#386 ACKs for top commit: Talkless: tACK 62b125f, tested on Debian Sid with 5.15.2 and it works as described. hebasto: re-ACK 62b125f, only removed the unused `SubFeeFromAmountChanged` signal since my [previous](bitcoin-core/gui#390 (review)) review. meshcollider: utACK 62b125f Tree-SHA512: 932ca89ae578a1e1c426561400d87cf005c231944feaf0f662ff8d88f32bdd65a927a090ea41510a15f8ec0ebcd5529672e9917720eb5ea85f413f081e45d5bb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the scriptPubKey for signing blocks never changes, there's no
point reading repeating it from every block header.
Subset of #313