HF: Move block.proof.challenge to Consensus::Params::signblockscript #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
jtimon
force-pushed
the
e14-blocksign-hf3
branch
from
7e86471 to
fe713a6
Compare
Contributor
Author
|
Fixed bug, checking hashPrevBlock.IsNull() instead of proof.IsNull() in CBlockHeader::IsNull(). Probably a good next simplification step is to remove the Proof class, now more clearly redundant. |
Contributor
|
utACK fe713a6 |
jtimon
force-pushed
the
e14-blocksign-hf3
branch
from
fe713a6 to
81b9ace
Compare
Contributor
Author
|
Rebased. Separating #386 out of this. |
jtimon
force-pushed
the
e14-blocksign-hf3
branch
2 times, most recently
from
60ac98f to
3765e6d
Compare
Since the scriptPubKey for signing blocks never changes, there's no point reading repeating it from every block header.
jtimon
force-pushed
the
e14-blocksign-hf3
branch
from
3765e6d to
96486e8
Compare
jtimon
changed the title
Since the scriptPubKey for signing blocks never changes, there's no point in repeating it with every block header.
jtimon
force-pushed
the
e14-blocksign-hf3
branch
from
96486e8 to
3311102
Compare
Contributor
Author
|
needs rebase |
Contributor
|
Needs port to master branch at some point. Will be undertaken for #534 . Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the scriptPubKey for signing blocks never changes, there's no
point in repeating it with every block header.
Closed #189 by accident, it seems restoring the branch doesn't make it, so I opened this one instead.
Dependencies: