Skip to content

Conversation

@dkuegler
Copy link
Member

@dkuegler dkuegler commented Jan 31, 2025

Make long_fastsurfer.sh support --threads seg=X and --threads surf=X notation bx fixing/adding support to long_prepare_template.sh

Add messages to parallel longitudinal processing to make waiting more clear Fix some variables in long_fastsurfer.sh

These flags were introduced in #640

This is tested and works as expected.

…notation bx fixing/adding support to lon_prepare_template.sh

Add messages to parallel longitudinal processing to make waiting more clear
Fix some variables in long_fastsurfer.sh
@dkuegler dkuegler marked this pull request as draft January 31, 2025 17:37
@dkuegler
Copy link
Member Author

This still currently has two (minor) issues:

  1. Longitudinal surfaces are not in-fact parallel but sequential.
  2. During longitudinal surfaces (in parallel mode) all run_fastsurfer log lines are doubled

@dkuegler
Copy link
Member Author

dkuegler commented Jan 31, 2025

Well, turns out both of these seem wrong. In fact, there is only a bug in brun_fastsurfer.sh that does not prefix the subject id correctly making it seem like double-logging of messages from one case. In fact, it is Single-Lifting two parallel processes :face-palm:

So in reality, I just need to fix this logging issue.

Independent of that, I think I should probably take a look at the log files as well and see if they can be deciphered as is or if the logging of parallel processes makes them impossible to read...

Fix check to decide whether the subject id should be prepended
@dkuegler dkuegler force-pushed the feature/long-parallel-threads branch from ab7e520 to 9e2042a Compare February 3, 2025 15:22
@dkuegler
Copy link
Member Author

dkuegler commented Feb 3, 2025

All issues are fixed

@dkuegler dkuegler marked this pull request as ready for review February 3, 2025 15:46
@m-reuter m-reuter merged commit 4b4292d into Deep-MI:dev Feb 3, 2025
3 checks passed
@dkuegler dkuegler deleted the feature/long-parallel-threads branch February 4, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants