-
Notifications
You must be signed in to change notification settings - Fork 469
fix(tracing): avoid raising index errors on partial flushes #15409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 247 ± 3 ms. The average import time from base is: 252 ± 3 ms. The import time difference between this PR and base is: -5.5 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate munir/fix-span-finish-partial-flush (8ce0ec5) with baseline main (3feb329) 📈 Performance Regressions (2 suites)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 4.993µs (SLO: <10.000µs 📉 -50.1%) vs baseline: 📈 +15.7% Memory: ✅ 40.265MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +5.3% ✅ ospathbasename_noaspectTime: ✅ 1.085µs (SLO: <10.000µs 📉 -89.2%) vs baseline: +0.1% Memory: ✅ 40.344MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +5.2% ✅ ospathjoin_aspectTime: ✅ 6.079µs (SLO: <10.000µs 📉 -39.2%) vs baseline: -1.5% Memory: ✅ 40.187MB (SLO: <41.000MB 🟡 -2.0%) vs baseline: +4.3% ✅ ospathjoin_noaspectTime: ✅ 2.281µs (SLO: <10.000µs 📉 -77.2%) vs baseline: -0.4% Memory: ✅ 40.285MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +4.9% ✅ ospathnormcase_aspectTime: ✅ 3.414µs (SLO: <10.000µs 📉 -65.9%) vs baseline: -2.3% Memory: ✅ 40.364MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +5.2% ✅ ospathnormcase_noaspectTime: ✅ 0.563µs (SLO: <10.000µs 📉 -94.4%) vs baseline: -1.6% Memory: ✅ 40.167MB (SLO: <41.000MB -2.0%) vs baseline: +4.7% ✅ ospathsplit_aspectTime: ✅ 4.717µs (SLO: <10.000µs 📉 -52.8%) vs baseline: -3.6% Memory: ✅ 40.285MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +5.1% ✅ ospathsplit_noaspectTime: ✅ 1.588µs (SLO: <10.000µs 📉 -84.1%) vs baseline: -0.5% Memory: ✅ 40.423MB (SLO: <41.000MB 🟡 -1.4%) vs baseline: +5.3% ✅ ospathsplitdrive_aspectTime: ✅ 3.680µs (SLO: <10.000µs 📉 -63.2%) vs baseline: -0.6% Memory: ✅ 40.305MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +5.0% ✅ ospathsplitdrive_noaspectTime: ✅ 0.689µs (SLO: <10.000µs 📉 -93.1%) vs baseline: -1.5% Memory: ✅ 40.501MB (SLO: <41.000MB 🟡 -1.2%) vs baseline: +5.5% ✅ ospathsplitext_aspectTime: ✅ 4.490µs (SLO: <10.000µs 📉 -55.1%) vs baseline: -2.5% Memory: ✅ 40.246MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +4.8% ✅ ospathsplitext_noaspectTime: ✅ 1.385µs (SLO: <10.000µs 📉 -86.2%) vs baseline: +0.7% Memory: ✅ 40.285MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +4.8% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.441µs (SLO: <20.000µs 📉 -82.8%) vs baseline: 📈 +15.0% Memory: ✅ 35.212MB (SLO: <35.500MB 🟡 -0.8%) vs baseline: +4.9% ✅ 1-count-metrics-100-timesTime: ✅ 198.830µs (SLO: <220.000µs -9.6%) vs baseline: -1.0% Memory: ✅ 35.232MB (SLO: <35.500MB 🟡 -0.8%) vs baseline: +4.8% ✅ 1-distribution-metric-1-timesTime: ✅ 3.274µs (SLO: <20.000µs 📉 -83.6%) vs baseline: -2.1% Memory: ✅ 35.193MB (SLO: <35.500MB 🟡 -0.9%) vs baseline: +4.7% ✅ 1-distribution-metrics-100-timesTime: ✅ 212.627µs (SLO: <230.000µs -7.6%) vs baseline: -1.9% Memory: ✅ 35.232MB (SLO: <35.500MB 🟡 -0.8%) vs baseline: +4.7% ✅ 1-gauge-metric-1-timesTime: ✅ 2.196µs (SLO: <20.000µs 📉 -89.0%) vs baseline: -4.0% Memory: ✅ 35.232MB (SLO: <35.500MB 🟡 -0.8%) vs baseline: +4.8% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.470µs (SLO: <150.000µs -9.0%) vs baseline: ~same Memory: ✅ 35.212MB (SLO: <35.500MB 🟡 -0.8%) vs baseline: +5.0% ✅ 1-rate-metric-1-timesTime: ✅ 3.070µs (SLO: <20.000µs 📉 -84.6%) vs baseline: -2.8% Memory: ✅ 35.311MB (SLO: <35.500MB 🟡 -0.5%) vs baseline: +5.1% ✅ 1-rate-metrics-100-timesTime: ✅ 213.725µs (SLO: <250.000µs 📉 -14.5%) vs baseline: -1.1% Memory: ✅ 35.232MB (SLO: <35.500MB 🟡 -0.8%) vs baseline: +4.9% ✅ 100-count-metrics-100-timesTime: ✅ 20.195ms (SLO: <22.000ms -8.2%) vs baseline: -0.3% Memory: ✅ 34.957MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +5.2% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.228ms (SLO: <2.300ms -3.1%) vs baseline: -1.2% Memory: ✅ 35.193MB (SLO: <35.500MB 🟡 -0.9%) vs baseline: +4.7% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.406ms (SLO: <1.550ms -9.3%) vs baseline: ~same Memory: ✅ 35.016MB (SLO: <35.500MB 🟡 -1.4%) vs baseline: +4.9% ✅ 100-rate-metrics-100-timesTime: ✅ 2.216ms (SLO: <2.550ms 📉 -13.1%) vs baseline: +0.5% Memory: ✅ 34.760MB (SLO: <35.500MB -2.1%) vs baseline: +4.4% ✅ flush-1-metricTime: ✅ 4.416µs (SLO: <20.000µs 📉 -77.9%) vs baseline: -1.9% Memory: ✅ 35.291MB (SLO: <35.500MB 🟡 -0.6%) vs baseline: +5.1% ✅ flush-100-metricsTime: ✅ 174.275µs (SLO: <250.000µs 📉 -30.3%) vs baseline: ~same Memory: ✅ 35.389MB (SLO: <35.500MB 🟡 -0.3%) vs baseline: +5.3% ✅ flush-1000-metricsTime: ✅ 2.187ms (SLO: <2.500ms 📉 -12.5%) vs baseline: -0.5% Memory: ✅ 36.117MB (SLO: <36.500MB 🟡 -1.0%) vs baseline: +5.0% 🟡 Near SLO Breach (18 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
995276c to
58c2f75
Compare
Description
Fixes an
IndexErrorinSpanAggregator.on_span_finish()when partial flush is enabled. The error occurred whennum_finished >= partial_flush_min_spansbutremove_finished()returned an empty list due to counter inconsistency.Fix:
finished[0]Risks
Low. Minimal change maintains O(1) performance for counting finished spans. Partial flush behavior unchanged when spans are available.