move testagent test

Author: mabdinur

tests/integration/test_integration_snapshots.py

@@ -352,3 +352,24 @@ def test_encode_span_with_large_unicode_string_attributes(encoding):
     with override_global_config(dict(_trace_api=encoding)):
         with tracer.trace(name="á" * 25000, resource="â" * 25001) as span:
             span.set_tag(key="å" * 25001, value="ä" * 2000)
+
+
+@pytest.mark.snapshot
+@pytest.mark.subprocess(env={"DD_TRACE_PARTIAL_FLUSH_ENABLED": "true", "DD_TRACE_PARTIAL_FLUSH_MIN_SPANS": "2"})
+def test_aggregator_partial_flush_finished_counter_out_of_sync():
+    """Regression test for IndexError when num_finished counter is out of sync with finished spans."""
+    from ddtrace import tracer
+
+    span1 = tracer.start_span("span1")
+    span2 = tracer.start_span("span2", child_of=span1)
+    span3 = tracer.start_span("span3", child_of=span1)
+    # Manually set duration_ns before finish() to simulate finished state
+    # This creates edge case: span1 appears finished but hasn't gone through on_span_finish yet
+    span1.duration_ns = 1
+    # span2 finishes, incrementing num_finished to 1
+    span2.finish()
+    # span1.finish() increments num_finished to 2, triggering partial flush check (2 >= 2)
+    # remove_finished() may return empty if span1 was already processed/removed
+    # Without defensive check, accessing finished[0] would raise IndexError
+    span1.finish()
+    span3.finish()

tests/snapshots/tests.tracer.test_processors.test_aggregator_partial_flush_finished_counter_out_of_sync.json renamed to tests/snapshots/tests.integration.test_integration_snapshots.test_aggregator_partial_flush_finished_counter_out_of_sync.json

@@ -10,18 +10,18 @@
     "error": 0,
     "meta": {
       "_dd.p.dm": "-0",
-      "_dd.p.tid": "6927e33800000000",
+      "_dd.p.tid": "6928928300000000",
       "language": "python",
-      "runtime-id": "ad4d778d938e4a2cb585384bd0b7eabf"
+      "runtime-id": "3f1e5366e3024949b5ea4186ef167625"
     },
     "metrics": {
       "_dd.py.partial_flush": 2.0,
       "_dd.tracer_kr": 1.0,
       "_sampling_priority_v1": 1.0,
-      "process_id": 49860.0
+      "process_id": 35909.0
     },
     "duration": 1,
-    "start": 1764221752629842000
+    "start": 1764266627479686000
   },
      {
        "name": "span2",
@@ -33,7 +33,7 @@
        "type": "",
        "error": 0,
        "duration": 12000,
-       "start": 1764221752629863000
+       "start": 1764266627479706000
      },
      {
        "name": "span3",
@@ -44,6 +44,6 @@
        "parent_id": 1,
        "type": "",
        "error": 0,
-       "duration": 10000,
-       "start": 1764221752629872000
+       "duration": 11000,
+       "start": 1764266627479714000
      }]]

tests/suitespec.yml

@@ -265,7 +265,7 @@ suites:
       - '@futures'
       - '@ci_visibility'
       - tests/tracer/*
-      - tests/snapshots/test*
+      - tests/snapshots/test_*
     retry: 2
     runner: riot
   vendor:

tests/tracer/test_processors.py

@@ -387,27 +387,6 @@ def test_aggregator_partial_flush_2_spans():
     assert parent.get_metric("_dd.py.partial_flush") is None
 
 
-@pytest.mark.snapshot
-@pytest.mark.subprocess(env={"DD_TRACE_PARTIAL_FLUSH_ENABLED": "true", "DD_TRACE_PARTIAL_FLUSH_MIN_SPANS": "2"})
-def test_aggregator_partial_flush_finished_counter_out_of_sync():
-    """Regression test for IndexError when num_finished counter is out of sync with finished spans."""
-    from ddtrace import tracer
-
-    span1 = tracer.start_span("span1")
-    span2 = tracer.start_span("span2", child_of=span1)
-    span3 = tracer.start_span("span3", child_of=span1)
-    # Manually set duration_ns before finish() to simulate finished state
-    # This creates edge case: span1 appears finished but hasn't gone through on_span_finish yet
-    span1.duration_ns = 1
-    # span2 finishes, incrementing num_finished to 1
-    span2.finish()
-    # span1.finish() increments num_finished to 2, triggering partial flush check (2 >= 2)
-    # remove_finished() may return empty if span1 was already processed/removed
-    # Without defensive check, accessing finished[0] would raise IndexError
-    span1.finish()
-    span3.finish()
-
-
 @pytest.mark.subprocess(env={"DD_TRACE_PARTIAL_FLUSH_ENABLED": "true", "DD_TRACE_PARTIAL_FLUSH_MIN_SPANS": "2"})
 def test_trace_top_level_span_processor_partial_flushing():
     """Parent span and child span have the same service name"""