-
Notifications
You must be signed in to change notification settings - Fork 312
Add reflect config for CSS and graalvm #9449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
On a related note these are missing fields identified after working the Client-Computed Stats of the tracer in DataDog/system-tests#5165 |
🎯 Code Coverage 🔗 Commit SHA: 2abc4da | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 14 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~2abc4da3ce, baseline=1.53.0-SNAPSHOT~3302583fe0
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1047460
Total [baseline] (8.659 s) : 0, 8658853
Agent [candidate] (1.051 s) : 0, 1051463
Total [candidate] (8.674 s) : 0, 8674148
section iast
Agent [baseline] (1.188 s) : 0, 1187888
Total [baseline] (9.341 s) : 0, 9341399
Agent [candidate] (1.184 s) : 0, 1184043
Total [candidate] (9.377 s) : 0, 9377462
gantt
title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~2abc4da3ce, baseline=1.53.0-SNAPSHOT~3302583fe0
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.45 ms) : 0, 1450
crashtracking [candidate] (1.464 ms) : 0, 1464
BytebuddyAgent [baseline] (732.596 ms) : 0, 732596
BytebuddyAgent [candidate] (734.602 ms) : 0, 734602
GlobalTracer [baseline] (242.526 ms) : 0, 242526
GlobalTracer [candidate] (244.818 ms) : 0, 244818
AppSec [baseline] (30.06 ms) : 0, 30060
AppSec [candidate] (30.462 ms) : 0, 30462
Debugger [baseline] (6.042 ms) : 0, 6042
Debugger [candidate] (6.103 ms) : 0, 6103
Remote Config [baseline] (672.119 µs) : 0, 672
Remote Config [candidate] (675.063 µs) : 0, 675
Telemetry [baseline] (13.106 ms) : 0, 13106
Telemetry [candidate] (12.299 ms) : 0, 12299
section iast
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.484 ms) : 0, 1484
BytebuddyAgent [baseline] (858.162 ms) : 0, 858162
BytebuddyAgent [candidate] (854.577 ms) : 0, 854577
GlobalTracer [baseline] (234.479 ms) : 0, 234479
GlobalTracer [candidate] (233.847 ms) : 0, 233847
AppSec [baseline] (25.922 ms) : 0, 25922
AppSec [candidate] (29.375 ms) : 0, 29375
Debugger [baseline] (5.801 ms) : 0, 5801
Debugger [candidate] (6.629 ms) : 0, 6629
Remote Config [baseline] (610.597 µs) : 0, 611
Remote Config [candidate] (603.511 µs) : 0, 604
Telemetry [baseline] (8.313 ms) : 0, 8313
Telemetry [candidate] (8.377 ms) : 0, 8377
IAST [baseline] (32.076 ms) : 0, 32076
IAST [candidate] (27.967 ms) : 0, 27967
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~2abc4da3ce, baseline=1.53.0-SNAPSHOT~3302583fe0
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.057 s) : 0, 1056775
Total [baseline] (10.9 s) : 0, 10899605
Agent [candidate] (1.05 s) : 0, 1050252
Total [candidate] (10.809 s) : 0, 10808900
section appsec
Agent [baseline] (1.228 s) : 0, 1228028
Total [baseline] (10.864 s) : 0, 10863646
Agent [candidate] (1.247 s) : 0, 1246925
Total [candidate] (10.96 s) : 0, 10960218
section iast
Agent [baseline] (1.183 s) : 0, 1183484
Total [baseline] (11.0 s) : 0, 10999799
Agent [candidate] (1.199 s) : 0, 1198683
Total [candidate] (11.026 s) : 0, 11025826
section profiling
Agent [baseline] (1.202 s) : 0, 1201608
Total [baseline] (10.909 s) : 0, 10909236
Agent [candidate] (1.201 s) : 0, 1201256
Total [candidate] (10.95 s) : 0, 10949942
gantt
title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~2abc4da3ce, baseline=1.53.0-SNAPSHOT~3302583fe0
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.469 ms) : 0, 1469
crashtracking [candidate] (1.473 ms) : 0, 1473
BytebuddyAgent [baseline] (739.513 ms) : 0, 739513
BytebuddyAgent [candidate] (735.5 ms) : 0, 735500
GlobalTracer [baseline] (244.987 ms) : 0, 244987
GlobalTracer [candidate] (244.043 ms) : 0, 244043
AppSec [baseline] (30.546 ms) : 0, 30546
AppSec [candidate] (30.228 ms) : 0, 30228
Debugger [baseline] (6.094 ms) : 0, 6094
Debugger [candidate] (6.071 ms) : 0, 6071
Remote Config [baseline] (674.238 µs) : 0, 674
Remote Config [candidate] (684.752 µs) : 0, 685
Telemetry [baseline] (12.274 ms) : 0, 12274
Telemetry [candidate] (10.974 ms) : 0, 10974
section appsec
crashtracking [baseline] (1.452 ms) : 0, 1452
crashtracking [candidate] (1.483 ms) : 0, 1483
BytebuddyAgent [baseline] (757.516 ms) : 0, 757516
BytebuddyAgent [candidate] (772.101 ms) : 0, 772101
GlobalTracer [baseline] (237.012 ms) : 0, 237012
GlobalTracer [candidate] (239.751 ms) : 0, 239751
AppSec [baseline] (170.483 ms) : 0, 170483
AppSec [candidate] (172.072 ms) : 0, 172072
Debugger [baseline] (6.632 ms) : 0, 6632
Debugger [candidate] (5.77 ms) : 0, 5770
Remote Config [baseline] (636.291 µs) : 0, 636
Remote Config [candidate] (655.789 µs) : 0, 656
Telemetry [baseline] (9.353 ms) : 0, 9353
Telemetry [candidate] (9.32 ms) : 0, 9320
IAST [baseline] (23.766 ms) : 0, 23766
IAST [candidate] (24.28 ms) : 0, 24280
section iast
crashtracking [baseline] (1.482 ms) : 0, 1482
crashtracking [candidate] (1.459 ms) : 0, 1459
BytebuddyAgent [baseline] (854.025 ms) : 0, 854025
BytebuddyAgent [candidate] (865.614 ms) : 0, 865614
GlobalTracer [baseline] (234.189 ms) : 0, 234189
GlobalTracer [candidate] (237.057 ms) : 0, 237057
AppSec [baseline] (24.187 ms) : 0, 24187
AppSec [candidate] (27.534 ms) : 0, 27534
Debugger [baseline] (7.598 ms) : 0, 7598
Debugger [candidate] (9.272 ms) : 0, 9272
Remote Config [baseline] (593.556 µs) : 0, 594
Remote Config [candidate] (620.374 µs) : 0, 620
Telemetry [baseline] (8.281 ms) : 0, 8281
Telemetry [candidate] (9.232 ms) : 0, 9232
IAST [baseline] (32.027 ms) : 0, 32027
IAST [candidate] (26.568 ms) : 0, 26568
section profiling
crashtracking [baseline] (1.44 ms) : 0, 1440
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (764.664 ms) : 0, 764664
BytebuddyAgent [candidate] (764.096 ms) : 0, 764096
GlobalTracer [baseline] (223.321 ms) : 0, 223321
GlobalTracer [candidate] (222.857 ms) : 0, 222857
AppSec [baseline] (30.065 ms) : 0, 30065
AppSec [candidate] (30.122 ms) : 0, 30122
Debugger [baseline] (6.263 ms) : 0, 6263
Debugger [candidate] (6.324 ms) : 0, 6324
Remote Config [baseline] (726.338 µs) : 0, 726
Remote Config [candidate] (724.292 µs) : 0, 724
Telemetry [baseline] (15.729 ms) : 0, 15729
Telemetry [candidate] (16.302 ms) : 0, 16302
ProfilingAgent [baseline] (108.894 ms) : 0, 108894
ProfilingAgent [candidate] (108.845 ms) : 0, 108845
Profiling [baseline] (109.548 ms) : 0, 109548
Profiling [candidate] (109.514 ms) : 0, 109514
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 11 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~2abc4da3ce, baseline=1.53.0-SNAPSHOT~3302583fe0
dateFormat X
axisFormat %s
section baseline
no_agent (4.184 ms) : 4136, 4233
. : milestone, 4184,
iast (9.676 ms) : 9513, 9838
. : milestone, 9676,
iast_FULL (14.25 ms) : 13968, 14531
. : milestone, 14250,
iast_GLOBAL (10.207 ms) : 10024, 10390
. : milestone, 10207,
profiling (8.864 ms) : 8723, 9005
. : milestone, 8864,
tracing (7.356 ms) : 7246, 7465
. : milestone, 7356,
section candidate
no_agent (4.216 ms) : 4168, 4263
. : milestone, 4216,
iast (9.386 ms) : 9231, 9541
. : milestone, 9386,
iast_FULL (14.385 ms) : 14097, 14673
. : milestone, 14385,
iast_GLOBAL (10.164 ms) : 9986, 10342
. : milestone, 10164,
profiling (8.708 ms) : 8573, 8843
. : milestone, 8708,
tracing (7.394 ms) : 7276, 7512
. : milestone, 7394,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~2abc4da3ce, baseline=1.53.0-SNAPSHOT~3302583fe0
dateFormat X
axisFormat %s
section baseline
no_agent (37.013 ms) : 36710, 37317
. : milestone, 37013,
appsec (48.895 ms) : 48459, 49330
. : milestone, 48895,
code_origins (43.803 ms) : 43429, 44178
. : milestone, 43803,
iast (45.379 ms) : 44973, 45785
. : milestone, 45379,
profiling (49.73 ms) : 49250, 50210
. : milestone, 49730,
tracing (45.097 ms) : 44726, 45468
. : milestone, 45097,
section candidate
no_agent (37.935 ms) : 37627, 38244
. : milestone, 37935,
appsec (49.49 ms) : 49043, 49937
. : milestone, 49490,
code_origins (45.369 ms) : 44991, 45748
. : milestone, 45369,
iast (44.746 ms) : 44367, 45124
. : milestone, 44746,
profiling (48.406 ms) : 47939, 48874
. : milestone, 48406,
tracing (44.6 ms) : 44234, 44966
. : milestone, 44600,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~2abc4da3ce, baseline=1.53.0-SNAPSHOT~3302583fe0
dateFormat X
axisFormat %s
section baseline
no_agent (15.505 s) : 15505000, 15505000
. : milestone, 15505000,
appsec (14.866 s) : 14866000, 14866000
. : milestone, 14866000,
iast (18.542 s) : 18542000, 18542000
. : milestone, 18542000,
iast_GLOBAL (18.275 s) : 18275000, 18275000
. : milestone, 18275000,
profiling (15.426 s) : 15426000, 15426000
. : milestone, 15426000,
tracing (15.07 s) : 15070000, 15070000
. : milestone, 15070000,
section candidate
no_agent (15.288 s) : 15288000, 15288000
. : milestone, 15288000,
appsec (15.141 s) : 15141000, 15141000
. : milestone, 15141000,
iast (19.115 s) : 19115000, 19115000
. : milestone, 19115000,
iast_GLOBAL (17.813 s) : 17813000, 17813000
. : milestone, 17813000,
profiling (15.567 s) : 15567000, 15567000
. : milestone, 15567000,
tracing (14.986 s) : 14986000, 14986000
. : milestone, 14986000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~2abc4da3ce, baseline=1.53.0-SNAPSHOT~3302583fe0
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (3.674 ms) : 3458, 3889
. : milestone, 3674,
iast (2.184 ms) : 2122, 2246
. : milestone, 2184,
iast_GLOBAL (2.236 ms) : 2173, 2299
. : milestone, 2236,
profiling (2.037 ms) : 1986, 2087
. : milestone, 2037,
tracing (2.012 ms) : 1964, 2061
. : milestone, 2012,
section candidate
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (3.65 ms) : 3434, 3865
. : milestone, 3650,
iast (2.202 ms) : 2140, 2265
. : milestone, 2202,
iast_GLOBAL (2.239 ms) : 2176, 2302
. : milestone, 2239,
profiling (2.044 ms) : 1993, 2095
. : milestone, 2044,
tracing (2.023 ms) : 1974, 2072
. : milestone, 2023,
|
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.52.1` -> `1.53.0` | --- ### Release Notes <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.53.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.53.0): 1.53.0 ### Components #### Application Security Management (WAF) - 🐛 Fix NullPointerException log in AppSec ([#​9355](DataDog/dd-trace-java#9355) - [@​jandro996](https://github.com/jandro996)) - ✨ Add Forwarded header as a source to client IP resolution ([#​9310](DataDog/dd-trace-java#9310) - [@​jandro996](https://github.com/jandro996)) #### Build & Tooling - 📖 Update CODEOWNERS ([#​9294](DataDog/dd-trace-java#9294) - [@​mhlidd](https://github.com/mhlidd)) - ✨ Add dependency on Maven Central deployment to OCI publish jobs ([#​9204](DataDog/dd-trace-java#9204) - [@​sarahchen6](https://github.com/sarahchen6)) #### Continuous Integration Visibility - ✨ Upload code coverage reports to Datadog ([#​9425](DataDog/dd-trace-java#9425) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨⚡ Do not follow symlinks by default when building repository index ([#​9318](DataDog/dd-trace-java#9318) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Improve tag propagation between test event levels ([#​9278](DataDog/dd-trace-java#9278) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) #### Data Streams Monitoring - ✨ Create container hash tags propagation ([#​9282](DataDog/dd-trace-java#9282) - [@​ygree](https://github.com/ygree)) #### Database Monitoring - 🐛 Prevent crash in SQL Server's JDBC when tracing execute methods with generated keys ([#​9321](DataDog/dd-trace-java#9321) - [@​na-ji](https://github.com/na-ji)) - ✨ Create container hash tags propagation ([#​9282](DataDog/dd-trace-java#9282) - [@​ygree](https://github.com/ygree)) #### GraalVM native-image - 🐛 Update GraalVM config to reflect TempLocationManager's new package ([#​9337](DataDog/dd-trace-java#9337) - [@​luneo7](https://github.com/luneo7) - thanks for the contribution!) #### Metrics - 🐛 Add reflect config for CSS and graalvm ([#​9449](DataDog/dd-trace-java#9449) - [@​amarziali](https://github.com/amarziali)) - ✨ Align CSS health metrics ([#​9444](DataDog/dd-trace-java#9444) - [@​amarziali](https://github.com/amarziali)) - ✨ Aggregate peer tags for consumer span kind ([#​9442](DataDog/dd-trace-java#9442) - [@​amarziali](https://github.com/amarziali)) - ✨ Implement health metrics for client stats ([#​9377](DataDog/dd-trace-java#9377) - [@​amarziali](https://github.com/amarziali)) - ✨ Add peer tags, span kind and trace root flag to MetricKey bucket ([#​9178](DataDog/dd-trace-java#9178) - [@​bric3](https://github.com/bric3)) #### Profiling - ✨ Create a profile flare reporter (requires tracing or CI vis to be enabled) ([#​9433](DataDog/dd-trace-java#9433) - [@​MattAlp](https://github.com/MattAlp)) - 🐛 Properly fall-back on UDS profiling URL ([#​9401](DataDog/dd-trace-java#9401) - [@​jbachorik](https://github.com/jbachorik)) - 🐛 Properly handle trace agent IPv6 URL in profiling ([#​9334](DataDog/dd-trace-java#9334) - [@​jbachorik](https://github.com/jbachorik)) #### Realtime User Monitoring - 🐛 Avoid multiple injections on dispatch on jboss ([#​9392](DataDog/dd-trace-java#9392) - [@​amarziali](https://github.com/amarziali)) - ✨ Support async servlet for RUM injection ([#​9333](DataDog/dd-trace-java#9333) - [@​amarziali](https://github.com/amarziali)) - 🐛 Improve RUM injection matching and avoid truncating responses ([#​9323](DataDog/dd-trace-java#9323) - [@​amarziali](https://github.com/amarziali)) - 💡 Add telemetry for the RUM injector ([#​9267](DataDog/dd-trace-java#9267) - [@​sarahchen6](https://github.com/sarahchen6)) - ✨ Make rum injector stream/writer more resilient to errors ([#​9184](DataDog/dd-trace-java#9184) - [@​amarziali](https://github.com/amarziali)) #### Telemetry - 🐛 Remediate error logs ([#​9459](DataDog/dd-trace-java#9459) - [@​ygree](https://github.com/ygree)) - ✨ Report config\_id for Hands Off Config files ([#​9299](DataDog/dd-trace-java#9299) - [@​mtoffl01](https://github.com/mtoffl01)) - ✨ Adding Config Inversion Telemetry component ([#​9244](DataDog/dd-trace-java#9244) - [@​mhlidd](https://github.com/mhlidd)) #### Trace context propagation - 🧹 Migrate instrumentations to Context API ([#​9384](DataDog/dd-trace-java#9384), [#​9378](DataDog/dd-trace-java#9378), [#​9358](DataDog/dd-trace-java#9358) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) - ✨🔍 Add baggage propagation telemetry ([#​9289](DataDog/dd-trace-java#9289) - [@​rachelyangdog](https://github.com/rachelyangdog)) - 🧹 Improve Instrumenter API to use Context instead of Span ([#​9211](DataDog/dd-trace-java#9211) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) #### Tracer core - 💡:test\_tube: Enable process level tags for java 21 applications ([#​9458](DataDog/dd-trace-java#9458) - [@​amarziali](https://github.com/amarziali)) - ✨ Move base and peer service adder before span is published ([#​9408](DataDog/dd-trace-java#9408) - [@​amarziali](https://github.com/amarziali)) - ✨ Add ErrorPriorities level for manual instrumentation ([#​9387](DataDog/dd-trace-java#9387) - [@​cecile75](https://github.com/cecile75)) - ✨ Throw InvalidBooleanValueException in ConfigConverter.booleanValueOf ([#​9370](DataDog/dd-trace-java#9370) - [@​mtoffl01](https://github.com/mtoffl01)) - 🐛 Avoid NPE on featureDiscovery creation ([#​9353](DataDog/dd-trace-java#9353) - [@​amarziali](https://github.com/amarziali)) - ✨ Stable Config improvements ([#​9259](DataDog/dd-trace-java#9259) - [@​mtoffl01](https://github.com/mtoffl01)) ### Instrumentations #### gRPC instrumentation - 🐛 Changing GRPC instrumentation codes from `status.code` to `grpc.status.code` ([#​9367](DataDog/dd-trace-java#9367) - [@​mhlidd](https://github.com/mhlidd)) #### JDBC instrumentation - 🐛 Prevent crash in SQL Server's JDBC when tracing execute methods with generated keys ([#​9321](DataDog/dd-trace-java#9321) - [@​na-ji](https://github.com/na-ji)) #### Kotlin instrumentation - 🐛 Take defensive copy of original scope stack when restoring on different thread ([#​9403](DataDog/dd-trace-java#9403) - [@​mcculls](https://github.com/mcculls)) #### OpenTelemetry instrumentation - 🐛 Fix using SpanAttribute annotation on multiple parameters ([#​9412](DataDog/dd-trace-java#9412) - [@​cecile75](https://github.com/cecile75)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: e23ec866cef91afc6b5226d5f0dc7da538d947e8
What Does This Do
ConflatingMetricsAggregator is using some jctools classes using unsafe reflection that were not declared.
Example:
Tests are enforced on system tests
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]