Changing GRPC instrumentation codes from `status.code` to `grpc.status.code` #9367

mhlidd · 2025-08-14T19:55:09Z

What Does This Do

Currently the Java tracer sets status codes for GRPC instrumentations as status.code. However, the agent does not accept this as a key when handling GRPC status codes, leading to situations where spans could show up with incorrect values for the tag grpc.status.code.

This PR updates the tag that the Java tracer sets for GRPC instrumentation status codes from status.code to grpc.status.code, which is accepted on the agent side.

Motivation

There was a discussion on whether this inconsistency should be normalized on the agent side, or handled in the Java Tracer. Given that only the Java tracer uses an inconsistent tag, it was decided that the change should be made in the tracer.

Additional Notes

This change needs to be called out in release notes, in the case where customers expecting status.code with alerts/dashboards and need to update to use grpc.status.code.

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

datadog-official · 2025-08-14T20:14:37Z

Code coverage: total 68.77%, base diff 11.33%, patch 100.00% (view details)

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: cfb2b6d | Docs | Was this helpful? Give us feedback!}

pr-commenter · 2025-08-14T21:01:46Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mhlidd/fix_grpc_status_codes
git_commit_date	1755609335	1755610056
git_commit_sha	`1f35448`	`cfb2b6d`
release_version	1.53.0-SNAPSHOT~1f3544809f	1.53.0-SNAPSHOT~cfb2b6d301

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1755611982	1755611982
ci_job_id	1086983779	1086983779
ci_pipeline_id	74113279	74113279
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-lx6gkxve 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-lx6gkxve 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 14 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~cfb2b6d301, baseline=1.53.0-SNAPSHOT~1f3544809f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1046221
Total [baseline] (8.579 s) : 0, 8578677
Agent [candidate] (1.046 s) : 0, 1045650
Total [candidate] (8.593 s) : 0, 8593275
section iast
Agent [baseline] (1.181 s) : 0, 1180707
Total [baseline] (9.339 s) : 0, 9339317
Agent [candidate] (1.18 s) : 0, 1179984
Total [candidate] (9.316 s) : 0, 9316066

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.046 s	-
Agent	iast	1.181 s	134.486 ms (12.9%)
Total	tracing	8.579 s	-
Total	iast	9.339 s	760.64 ms (8.9%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.046 s	-
Agent	iast	1.18 s	134.335 ms (12.8%)
Total	tracing	8.593 s	-
Total	iast	9.316 s	722.791 ms (8.4%)

gantt
    title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~cfb2b6d301, baseline=1.53.0-SNAPSHOT~1f3544809f

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.456 ms) : 0, 1456
crashtracking [candidate] (1.443 ms) : 0, 1443
BytebuddyAgent [baseline] (731.433 ms) : 0, 731433
BytebuddyAgent [candidate] (730.731 ms) : 0, 730731
GlobalTracer [baseline] (242.535 ms) : 0, 242535
GlobalTracer [candidate] (242.195 ms) : 0, 242195
AppSec [baseline] (29.993 ms) : 0, 29993
AppSec [candidate] (30.059 ms) : 0, 30059
Debugger [baseline] (6.058 ms) : 0, 6058
Debugger [candidate] (6.043 ms) : 0, 6043
Remote Config [baseline] (674.897 µs) : 0, 675
Remote Config [candidate] (658.1 µs) : 0, 658
Telemetry [baseline] (13.043 ms) : 0, 13043
Telemetry [candidate] (13.564 ms) : 0, 13564
section iast
crashtracking [baseline] (1.45 ms) : 0, 1450
crashtracking [candidate] (1.45 ms) : 0, 1450
BytebuddyAgent [baseline] (851.852 ms) : 0, 851852
BytebuddyAgent [candidate] (851.886 ms) : 0, 851886
GlobalTracer [baseline] (233.618 ms) : 0, 233618
GlobalTracer [candidate] (234.13 ms) : 0, 234130
IAST [baseline] (30.499 ms) : 0, 30499
IAST [candidate] (29.999 ms) : 0, 29999
AppSec [baseline] (25.959 ms) : 0, 25959
AppSec [candidate] (26.046 ms) : 0, 26046
Debugger [baseline] (7.424 ms) : 0, 7424
Debugger [candidate] (6.595 ms) : 0, 6595
Remote Config [baseline] (605.439 µs) : 0, 605
Remote Config [candidate] (601.954 µs) : 0, 602
Telemetry [baseline] (8.219 ms) : 0, 8219
Telemetry [candidate] (8.229 ms) : 0, 8229

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~cfb2b6d301, baseline=1.53.0-SNAPSHOT~1f3544809f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1046918
Total [baseline] (10.723 s) : 0, 10723269
Agent [candidate] (1.046 s) : 0, 1046308
Total [candidate] (10.677 s) : 0, 10676547
section appsec
Agent [baseline] (1.224 s) : 0, 1223727
Total [baseline] (10.768 s) : 0, 10767861
Agent [candidate] (1.224 s) : 0, 1224087
Total [candidate] (10.815 s) : 0, 10815113
section iast
Agent [baseline] (1.177 s) : 0, 1176942
Total [baseline] (10.869 s) : 0, 10869307
Agent [candidate] (1.179 s) : 0, 1178842
Total [candidate] (10.878 s) : 0, 10878075
section profiling
Agent [baseline] (1.197 s) : 0, 1197041
Total [baseline] (10.905 s) : 0, 10904618
Agent [candidate] (1.199 s) : 0, 1198606
Total [candidate] (10.952 s) : 0, 10952209

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.047 s	-
Agent	appsec	1.224 s	176.808 ms (16.9%)
Agent	iast	1.177 s	130.024 ms (12.4%)
Agent	profiling	1.197 s	150.123 ms (14.3%)
Total	tracing	10.723 s	-
Total	appsec	10.768 s	44.592 ms (0.4%)
Total	iast	10.869 s	146.038 ms (1.4%)
Total	profiling	10.905 s	181.349 ms (1.7%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.046 s	-
Agent	appsec	1.224 s	177.78 ms (17.0%)
Agent	iast	1.179 s	132.534 ms (12.7%)
Agent	profiling	1.199 s	152.299 ms (14.6%)
Total	tracing	10.677 s	-
Total	appsec	10.815 s	138.566 ms (1.3%)
Total	iast	10.878 s	201.528 ms (1.9%)
Total	profiling	10.952 s	275.662 ms (2.6%)

gantt
    title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~cfb2b6d301, baseline=1.53.0-SNAPSHOT~1f3544809f

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.447 ms) : 0, 1447
crashtracking [candidate] (1.446 ms) : 0, 1446
BytebuddyAgent [baseline] (732.24 ms) : 0, 732240
BytebuddyAgent [candidate] (731.382 ms) : 0, 731382
GlobalTracer [baseline] (242.407 ms) : 0, 242407
GlobalTracer [candidate] (242.243 ms) : 0, 242243
AppSec [baseline] (30.081 ms) : 0, 30081
AppSec [candidate] (30.015 ms) : 0, 30015
Debugger [baseline] (6.048 ms) : 0, 6048
Debugger [candidate] (6.023 ms) : 0, 6023
Remote Config [baseline] (668.559 µs) : 0, 669
Remote Config [candidate] (668.816 µs) : 0, 669
Telemetry [baseline] (12.91 ms) : 0, 12910
Telemetry [candidate] (13.492 ms) : 0, 13492
section appsec
crashtracking [baseline] (1.448 ms) : 0, 1448
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (755.643 ms) : 0, 755643
BytebuddyAgent [candidate] (756.093 ms) : 0, 756093
GlobalTracer [baseline] (235.173 ms) : 0, 235173
GlobalTracer [candidate] (235.642 ms) : 0, 235642
IAST [baseline] (23.635 ms) : 0, 23635
IAST [candidate] (23.438 ms) : 0, 23438
AppSec [baseline] (170.291 ms) : 0, 170291
AppSec [candidate] (170.679 ms) : 0, 170679
Debugger [baseline] (6.548 ms) : 0, 6548
Debugger [candidate] (6.544 ms) : 0, 6544
Remote Config [baseline] (633.913 µs) : 0, 634
Remote Config [candidate] (632.957 µs) : 0, 633
Telemetry [baseline] (9.255 ms) : 0, 9255
Telemetry [candidate] (8.457 ms) : 0, 8457
section iast
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.45 ms) : 0, 1450
BytebuddyAgent [baseline] (849.493 ms) : 0, 849493
BytebuddyAgent [candidate] (850.46 ms) : 0, 850460
GlobalTracer [baseline] (232.755 ms) : 0, 232755
GlobalTracer [candidate] (232.943 ms) : 0, 232943
IAST [baseline] (31.93 ms) : 0, 31930
IAST [candidate] (28.774 ms) : 0, 28774
AppSec [baseline] (25.759 ms) : 0, 25759
AppSec [candidate] (28.523 ms) : 0, 28523
Debugger [baseline] (5.722 ms) : 0, 5722
Debugger [candidate] (6.573 ms) : 0, 6573
Remote Config [baseline] (596.112 µs) : 0, 596
Remote Config [candidate] (601.637 µs) : 0, 602
Telemetry [baseline] (8.244 ms) : 0, 8244
Telemetry [candidate] (8.382 ms) : 0, 8382
section profiling
crashtracking [baseline] (1.426 ms) : 0, 1426
crashtracking [candidate] (1.422 ms) : 0, 1422
BytebuddyAgent [baseline] (762.501 ms) : 0, 762501
BytebuddyAgent [candidate] (762.266 ms) : 0, 762266
GlobalTracer [baseline] (222.135 ms) : 0, 222135
GlobalTracer [candidate] (222.695 ms) : 0, 222695
AppSec [baseline] (30.696 ms) : 0, 30696
AppSec [candidate] (29.945 ms) : 0, 29945
Debugger [baseline] (7.84 ms) : 0, 7840
Debugger [candidate] (7.054 ms) : 0, 7054
Remote Config [baseline] (700.777 µs) : 0, 701
Remote Config [candidate] (715.24 µs) : 0, 715
Telemetry [baseline] (13.079 ms) : 0, 13079
Telemetry [candidate] (15.832 ms) : 0, 15832
ProfilingAgent [baseline] (108.94 ms) : 0, 108940
ProfilingAgent [candidate] (109.021 ms) : 0, 109021
Profiling [baseline] (109.562 ms) : 0, 109562
Profiling [candidate] (109.686 ms) : 0, 109686

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mhlidd/fix_grpc_status_codes
git_commit_date	1755609335	1755610056
git_commit_sha	`1f35448`	`cfb2b6d`
release_version	1.53.0-SNAPSHOT~1f3544809f	1.53.0-SNAPSHOT~cfb2b6d301

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1755611740	1755611740
ci_job_id	1086983780	1086983780
ci_pipeline_id	74113279	74113279
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-2-0jbu65rq 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-2-0jbu65rq 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 3 performance improvements and 1 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:iast:high_load	worse [+438.725µs; +794.694µs] or [+4.770%; +8.640%]	unstable [-94.114op/s; +30.927op/s] or [-18.646%; +6.127%]	9.815ms	473.156op/s	9.198ms	504.750op/s
scenario:load:insecure-bank:tracing:high_load	better [-427.074µs; -192.982µs] or [-5.402%; -2.441%]	unstable [-54.165op/s; +101.415op/s] or [-9.244%; +17.308%]	7.596ms	609.562op/s	7.906ms	585.938op/s
scenario:load:petclinic:appsec:high_load	better [-3.244ms; -2.284ms] or [-6.482%; -4.565%]	unstable [-2.701op/s; +11.259op/s] or [-2.852%; +11.888%]	47.277ms	98.987op/s	50.041ms	94.709op/s
scenario:load:petclinic:code_origins:high_load	better [-2.259ms; -1.369ms] or [-4.778%; -2.895%]	unstable [-4.216op/s; +9.660op/s] or [-4.206%; +9.638%]	45.467ms	102.950op/s	47.281ms	100.228op/s

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~cfb2b6d301, baseline=1.53.0-SNAPSHOT~1f3544809f
    dateFormat X
    axisFormat %s
section baseline
no_agent (37.809 ms) : 37494, 38125
.   : milestone, 37809,
appsec (50.041 ms) : 49582, 50499
.   : milestone, 50041,
code_origins (47.281 ms) : 46852, 47709
.   : milestone, 47281,
iast (45.287 ms) : 44890, 45684
.   : milestone, 45287,
profiling (49.517 ms) : 49036, 49997
.   : milestone, 49517,
tracing (44.978 ms) : 44616, 45341
.   : milestone, 44978,
section candidate
no_agent (37.423 ms) : 37120, 37725
.   : milestone, 37423,
appsec (47.277 ms) : 46844, 47709
.   : milestone, 47277,
code_origins (45.467 ms) : 45069, 45865
.   : milestone, 45467,
iast (45.118 ms) : 44719, 45516
.   : milestone, 45118,
profiling (48.951 ms) : 48473, 49429
.   : milestone, 48951,
tracing (45.171 ms) : 44783, 45558
.   : milestone, 45171,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	37.809 ms [37.494 ms, 38.125 ms]	-
appsec	50.041 ms [49.582 ms, 50.499 ms]	12.231 ms (32.3%)
code_origins	47.281 ms [46.852 ms, 47.709 ms]	9.471 ms (25.1%)
iast	45.287 ms [44.89 ms, 45.684 ms]	7.478 ms (19.8%)
profiling	49.517 ms [49.036 ms, 49.997 ms]	11.707 ms (31.0%)
tracing	44.978 ms [44.616 ms, 45.341 ms]	7.169 ms (19.0%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	37.423 ms [37.12 ms, 37.725 ms]	-
appsec	47.277 ms [46.844 ms, 47.709 ms]	9.854 ms (26.3%)
code_origins	45.467 ms [45.069 ms, 45.865 ms]	8.044 ms (21.5%)
iast	45.118 ms [44.719 ms, 45.516 ms]	7.695 ms (20.6%)
profiling	48.951 ms [48.473 ms, 49.429 ms]	11.528 ms (30.8%)
tracing	45.171 ms [44.783 ms, 45.558 ms]	7.748 ms (20.7%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~cfb2b6d301, baseline=1.53.0-SNAPSHOT~1f3544809f
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.651 ms) : 4596, 4707
.   : milestone, 4651,
iast (9.198 ms) : 9040, 9356
.   : milestone, 9198,
iast_FULL (14.113 ms) : 13828, 14398
.   : milestone, 14113,
iast_GLOBAL (10.132 ms) : 9959, 10305
.   : milestone, 10132,
profiling (9.047 ms) : 8884, 9211
.   : milestone, 9047,
tracing (7.906 ms) : 7794, 8018
.   : milestone, 7906,
section candidate
no_agent (4.589 ms) : 4532, 4647
.   : milestone, 4589,
iast (9.815 ms) : 9642, 9987
.   : milestone, 9815,
iast_FULL (14.171 ms) : 13880, 14461
.   : milestone, 14171,
iast_GLOBAL (9.867 ms) : 9679, 10054
.   : milestone, 9867,
profiling (9.081 ms) : 8943, 9219
.   : milestone, 9081,
tracing (7.596 ms) : 7491, 7702
.   : milestone, 7596,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.651 ms [4.596 ms, 4.707 ms]	-
iast	9.198 ms [9.04 ms, 9.356 ms]	4.547 ms (97.7%)
iast_FULL	14.113 ms [13.828 ms, 14.398 ms]	9.462 ms (203.4%)
iast_GLOBAL	10.132 ms [9.959 ms, 10.305 ms]	5.481 ms (117.8%)
profiling	9.047 ms [8.884 ms, 9.211 ms]	4.396 ms (94.5%)
tracing	7.906 ms [7.794 ms, 8.018 ms]	3.255 ms (70.0%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.589 ms [4.532 ms, 4.647 ms]	-
iast	9.815 ms [9.642 ms, 9.987 ms]	5.226 ms (113.9%)
iast_FULL	14.171 ms [13.88 ms, 14.461 ms]	9.581 ms (208.8%)
iast_GLOBAL	9.867 ms [9.679 ms, 10.054 ms]	5.277 ms (115.0%)
profiling	9.081 ms [8.943 ms, 9.219 ms]	4.492 ms (97.9%)
tracing	7.596 ms [7.491 ms, 7.702 ms]	3.007 ms (65.5%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mhlidd/fix_grpc_status_codes
git_commit_date	1755609335	1755610056
git_commit_sha	`1f35448`	`cfb2b6d`
release_version	1.53.0-SNAPSHOT~1f3544809f	1.53.0-SNAPSHOT~cfb2b6d301

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1755612172	1755612172
ci_job_id	1086983781	1086983781
ci_pipeline_id	74113279	74113279
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-9kkme9m4 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-9kkme9m4 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~cfb2b6d301, baseline=1.53.0-SNAPSHOT~1f3544809f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.476 ms) : 1464, 1487
.   : milestone, 1476,
appsec (3.658 ms) : 3442, 3875
.   : milestone, 3658,
iast (2.191 ms) : 2129, 2254
.   : milestone, 2191,
iast_GLOBAL (2.241 ms) : 2178, 2305
.   : milestone, 2241,
profiling (2.061 ms) : 2009, 2113
.   : milestone, 2061,
tracing (2.025 ms) : 1976, 2075
.   : milestone, 2025,
section candidate
no_agent (1.471 ms) : 1460, 1483
.   : milestone, 1471,
appsec (3.613 ms) : 3400, 3827
.   : milestone, 3613,
iast (2.197 ms) : 2134, 2260
.   : milestone, 2197,
iast_GLOBAL (2.241 ms) : 2178, 2304
.   : milestone, 2241,
profiling (2.062 ms) : 2010, 2115
.   : milestone, 2062,
tracing (2.015 ms) : 1967, 2064
.   : milestone, 2015,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.476 ms [1.464 ms, 1.487 ms]	-
appsec	3.658 ms [3.442 ms, 3.875 ms]	2.183 ms (147.9%)
iast	2.191 ms [2.129 ms, 2.254 ms]	715.624 µs (48.5%)
iast_GLOBAL	2.241 ms [2.178 ms, 2.305 ms]	765.427 µs (51.9%)
profiling	2.061 ms [2.009 ms, 2.113 ms]	585.258 µs (39.7%)
tracing	2.025 ms [1.976 ms, 2.075 ms]	549.73 µs (37.3%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.471 ms [1.46 ms, 1.483 ms]	-
appsec	3.613 ms [3.4 ms, 3.827 ms]	2.142 ms (145.6%)
iast	2.197 ms [2.134 ms, 2.26 ms]	725.596 µs (49.3%)
iast_GLOBAL	2.241 ms [2.178 ms, 2.304 ms]	769.465 µs (52.3%)
profiling	2.062 ms [2.01 ms, 2.115 ms]	591.063 µs (40.2%)
tracing	2.015 ms [1.967 ms, 2.064 ms]	543.903 µs (37.0%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~cfb2b6d301, baseline=1.53.0-SNAPSHOT~1f3544809f
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.028 s) : 15028000, 15028000
.   : milestone, 15028000,
appsec (14.859 s) : 14859000, 14859000
.   : milestone, 14859000,
iast (18.242 s) : 18242000, 18242000
.   : milestone, 18242000,
iast_GLOBAL (18.363 s) : 18363000, 18363000
.   : milestone, 18363000,
profiling (15.48 s) : 15480000, 15480000
.   : milestone, 15480000,
tracing (15.034 s) : 15034000, 15034000
.   : milestone, 15034000,
section candidate
no_agent (15.236 s) : 15236000, 15236000
.   : milestone, 15236000,
appsec (14.922 s) : 14922000, 14922000
.   : milestone, 14922000,
iast (18.18 s) : 18180000, 18180000
.   : milestone, 18180000,
iast_GLOBAL (18.075 s) : 18075000, 18075000
.   : milestone, 18075000,
profiling (15.128 s) : 15128000, 15128000
.   : milestone, 15128000,
tracing (14.949 s) : 14949000, 14949000
.   : milestone, 14949000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.028 s [15.028 s, 15.028 s]	-
appsec	14.859 s [14.859 s, 14.859 s]	-169.0 ms (-1.1%)
iast	18.242 s [18.242 s, 18.242 s]	3.214 s (21.4%)
iast_GLOBAL	18.363 s [18.363 s, 18.363 s]	3.335 s (22.2%)
profiling	15.48 s [15.48 s, 15.48 s]	452.0 ms (3.0%)
tracing	15.034 s [15.034 s, 15.034 s]	6.0 ms (0.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.236 s [15.236 s, 15.236 s]	-
appsec	14.922 s [14.922 s, 14.922 s]	-314.0 ms (-2.1%)
iast	18.18 s [18.18 s, 18.18 s]	2.944 s (19.3%)
iast_GLOBAL	18.075 s [18.075 s, 18.075 s]	2.839 s (18.6%)
profiling	15.128 s [15.128 s, 15.128 s]	-108.0 ms (-0.7%)
tracing	14.949 s [14.949 s, 14.949 s]	-287.0 ms (-1.9%)

github-actions · 2025-08-15T14:44:18Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

amarziali · 2025-08-18T08:57:12Z

....84/src/main/java/datadog/trace/instrumentation/armeria/grpc/client/GrpcClientDecorator.java


  public AgentSpan onClose(final AgentSpan span, final Status status) {

-    span.setTag("status.code", status.getCode().name());


what about leaving both? Suppressing a tag is a breaking change. I would also discuss with IDM about that

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.52.1` -> `1.53.0` | --- ### Release Notes <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.53.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.53.0): 1.53.0 ### Components #### Application Security Management (WAF) - 🐛 Fix NullPointerException log in AppSec ([#9355](DataDog/dd-trace-java#9355) - [@jandro996](https://github.com/jandro996)) - ✨ Add Forwarded header as a source to client IP resolution ([#9310](DataDog/dd-trace-java#9310) - [@jandro996](https://github.com/jandro996)) #### Build & Tooling - 📖 Update CODEOWNERS ([#9294](DataDog/dd-trace-java#9294) - [@mhlidd](https://github.com/mhlidd)) - ✨ Add dependency on Maven Central deployment to OCI publish jobs ([#9204](DataDog/dd-trace-java#9204) - [@sarahchen6](https://github.com/sarahchen6)) #### Continuous Integration Visibility - ✨ Upload code coverage reports to Datadog ([#9425](DataDog/dd-trace-java#9425) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨⚡ Do not follow symlinks by default when building repository index ([#9318](DataDog/dd-trace-java#9318) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Improve tag propagation between test event levels ([#9278](DataDog/dd-trace-java#9278) - [@daniel-mohedano](https://github.com/daniel-mohedano)) #### Data Streams Monitoring - ✨ Create container hash tags propagation ([#9282](DataDog/dd-trace-java#9282) - [@ygree](https://github.com/ygree)) #### Database Monitoring - 🐛 Prevent crash in SQL Server's JDBC when tracing execute methods with generated keys ([#9321](DataDog/dd-trace-java#9321) - [@na-ji](https://github.com/na-ji)) - ✨ Create container hash tags propagation ([#9282](DataDog/dd-trace-java#9282) - [@ygree](https://github.com/ygree)) #### GraalVM native-image - 🐛 Update GraalVM config to reflect TempLocationManager's new package ([#9337](DataDog/dd-trace-java#9337) - [@luneo7](https://github.com/luneo7) - thanks for the contribution!) #### Metrics - 🐛 Add reflect config for CSS and graalvm ([#9449](DataDog/dd-trace-java#9449) - [@amarziali](https://github.com/amarziali)) - ✨ Align CSS health metrics ([#9444](DataDog/dd-trace-java#9444) - [@amarziali](https://github.com/amarziali)) - ✨ Aggregate peer tags for consumer span kind ([#9442](DataDog/dd-trace-java#9442) - [@amarziali](https://github.com/amarziali)) - ✨ Implement health metrics for client stats ([#9377](DataDog/dd-trace-java#9377) - [@amarziali](https://github.com/amarziali)) - ✨ Add peer tags, span kind and trace root flag to MetricKey bucket ([#9178](DataDog/dd-trace-java#9178) - [@bric3](https://github.com/bric3)) #### Profiling - ✨ Create a profile flare reporter (requires tracing or CI vis to be enabled) ([#9433](DataDog/dd-trace-java#9433) - [@MattAlp](https://github.com/MattAlp)) - 🐛 Properly fall-back on UDS profiling URL ([#9401](DataDog/dd-trace-java#9401) - [@jbachorik](https://github.com/jbachorik)) - 🐛 Properly handle trace agent IPv6 URL in profiling ([#9334](DataDog/dd-trace-java#9334) - [@jbachorik](https://github.com/jbachorik)) #### Realtime User Monitoring - 🐛 Avoid multiple injections on dispatch on jboss ([#9392](DataDog/dd-trace-java#9392) - [@amarziali](https://github.com/amarziali)) - ✨ Support async servlet for RUM injection ([#9333](DataDog/dd-trace-java#9333) - [@amarziali](https://github.com/amarziali)) - 🐛 Improve RUM injection matching and avoid truncating responses ([#9323](DataDog/dd-trace-java#9323) - [@amarziali](https://github.com/amarziali)) - 💡 Add telemetry for the RUM injector ([#9267](DataDog/dd-trace-java#9267) - [@sarahchen6](https://github.com/sarahchen6)) - ✨ Make rum injector stream/writer more resilient to errors ([#9184](DataDog/dd-trace-java#9184) - [@amarziali](https://github.com/amarziali)) #### Telemetry - 🐛 Remediate error logs ([#9459](DataDog/dd-trace-java#9459) - [@ygree](https://github.com/ygree)) - ✨ Report config\_id for Hands Off Config files ([#9299](DataDog/dd-trace-java#9299) - [@mtoffl01](https://github.com/mtoffl01)) - ✨ Adding Config Inversion Telemetry component ([#9244](DataDog/dd-trace-java#9244) - [@mhlidd](https://github.com/mhlidd)) #### Trace context propagation - 🧹 Migrate instrumentations to Context API ([#9384](DataDog/dd-trace-java#9384), [#9378](DataDog/dd-trace-java#9378), [#9358](DataDog/dd-trace-java#9358) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨🔍 Add baggage propagation telemetry ([#9289](DataDog/dd-trace-java#9289) - [@rachelyangdog](https://github.com/rachelyangdog)) - 🧹 Improve Instrumenter API to use Context instead of Span ([#9211](DataDog/dd-trace-java#9211) - [@PerfectSlayer](https://github.com/PerfectSlayer)) #### Tracer core - 💡:test\_tube: Enable process level tags for java 21 applications ([#9458](DataDog/dd-trace-java#9458) - [@amarziali](https://github.com/amarziali)) - ✨ Move base and peer service adder before span is published ([#9408](DataDog/dd-trace-java#9408) - [@amarziali](https://github.com/amarziali)) - ✨ Add ErrorPriorities level for manual instrumentation ([#9387](DataDog/dd-trace-java#9387) - [@cecile75](https://github.com/cecile75)) - ✨ Throw InvalidBooleanValueException in ConfigConverter.booleanValueOf ([#9370](DataDog/dd-trace-java#9370) - [@mtoffl01](https://github.com/mtoffl01)) - 🐛 Avoid NPE on featureDiscovery creation ([#9353](DataDog/dd-trace-java#9353) - [@amarziali](https://github.com/amarziali)) - ✨ Stable Config improvements ([#9259](DataDog/dd-trace-java#9259) - [@mtoffl01](https://github.com/mtoffl01)) ### Instrumentations #### gRPC instrumentation - 🐛 Changing GRPC instrumentation codes from `status.code` to `grpc.status.code` ([#9367](DataDog/dd-trace-java#9367) - [@mhlidd](https://github.com/mhlidd)) #### JDBC instrumentation - 🐛 Prevent crash in SQL Server's JDBC when tracing execute methods with generated keys ([#9321](DataDog/dd-trace-java#9321) - [@na-ji](https://github.com/na-ji)) #### Kotlin instrumentation - 🐛 Take defensive copy of original scope stack when restoring on different thread ([#9403](DataDog/dd-trace-java#9403) - [@mcculls](https://github.com/mcculls)) #### OpenTelemetry instrumentation - 🐛 Fix using SpanAttribute annotation on multiple parameters ([#9412](DataDog/dd-trace-java#9412) - [@cecile75](https://github.com/cecile75)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: e23ec866cef91afc6b5226d5f0dc7da538d947e8

Changing GRPC instrumentation codes from status.code to grpc.status.code

a802f55

adding grpc.status.code to pubsub tests

9230819

mhlidd marked this pull request as ready for review August 15, 2025 14:44

mhlidd requested a review from a team as a code owner August 15, 2025 14:44

mhlidd requested a review from amarziali August 15, 2025 14:45

mhlidd added type: bug Bug report and fix inst: grpc gRPC instrumentation labels Aug 15, 2025

amarziali reviewed Aug 18, 2025

View reviewed changes

updating to have both tags be sent

01abfec

amarziali approved these changes Aug 19, 2025

View reviewed changes

mhlidd enabled auto-merge (squash) August 19, 2025 13:27

Merge branch 'master' into mhlidd/fix_grpc_status_codes

cfb2b6d

mhlidd disabled auto-merge August 19, 2025 13:27

mhlidd merged commit a31bd14 into master Aug 19, 2025
499 checks passed

mhlidd deleted the mhlidd/fix_grpc_status_codes branch August 19, 2025 14:12

github-actions bot added this to the 1.53.0 milestone Aug 19, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Changing GRPC instrumentation codes from `status.code` to `grpc.status.code` #9367

Changing GRPC instrumentation codes from `status.code` to `grpc.status.code` #9367

Uh oh!

mhlidd commented Aug 14, 2025 •

edited

Loading

Uh oh!

datadog-official bot commented Aug 14, 2025 •

edited

Loading

Uh oh!

pr-commenter bot commented Aug 14, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Aug 15, 2025 •

edited

Loading

Uh oh!

amarziali Aug 18, 2025

Uh oh!

Uh oh!

Uh oh!


		public AgentSpan onClose(final AgentSpan span, final Status status) {

		span.setTag("status.code", status.getCode().name());

Changing GRPC instrumentation codes from status.code to grpc.status.code #9367

Changing GRPC instrumentation codes from status.code to grpc.status.code #9367

Uh oh!

Conversation

mhlidd commented Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

datadog-official bot commented Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter bot commented Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

github-actions bot commented Aug 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amarziali Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Changing GRPC instrumentation codes from `status.code` to `grpc.status.code` #9367

Changing GRPC instrumentation codes from `status.code` to `grpc.status.code` #9367

mhlidd commented Aug 14, 2025 •

edited

Loading

datadog-official bot commented Aug 14, 2025 •

edited

Loading

pr-commenter bot commented Aug 14, 2025 •

edited

Loading

github-actions bot commented Aug 15, 2025 •

edited

Loading