✨ [FFL-24] add openfeature dependency and datadog provider #3554

leoromanovsky · 2025-05-22T07:08:19Z

Motivation

Changes

🚧 Adds an open feature provider

This will be the basis for datadog flagging customers interacting with the API. It's methods are not yet implemented.

🐛 Fix a bug in the license check file

The output was being reported as:

Package.json dependencies and LICENSE-3rdparty.csv mismatch
 In package.json but not in LICENSE-3rdparty.csv:
 []
 In LICENSE-3rdparty.csv but not in package.json:
 []

Script exited with error: Error: Dependencies mismatch
    at /Users/leo.romanovsky/src/browser-sdk/scripts/check-licenses.js:33:11
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)

This should indicate no error but CI was failing.

✔️ I validated that the script is working by removing entries for open feature from the license file and verifying that the check works:

 Package.json dependencies and LICENSE-3rdparty.csv mismatch
 In package.json but not in LICENSE-3rdparty.csv:
 [ '@openfeature/core', '@openfeature/web-sdk' ]

Script exited with error: Error: Dependencies mismatch
    at /Users/leo.romanovsky/src/browser-sdk/scripts/check-licenses.js:40:9
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)

Test instructions

Added units tests to verify provider correctness (all functions return false)

Checklist

Tested locally
Tested on staging
Added unit tests for this change.
Added e2e/integration tests for this change.

codecov-commenter · 2025-05-22T07:22:53Z

Codecov Report

Attention: Patch coverage is 82.03125% with 23 lines in your changes missing coverage. Please review.

Project coverage is 92.19%. Comparing base (5cf79a7) to head (71afc70).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...g/src/configuration-wire/configurationWireTypes.ts	38.88%	11 Missing ⚠️
packages/flagging/src/precomputeClient.ts	83.33%	10 Missing ⚠️
packages/flagging/src/openfeature/provider.ts	94.44%	1 Missing ⚠️
packages/flagging/test/helpers.ts	83.33%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3554      +/-   ##
==========================================
- Coverage   92.34%   92.19%   -0.15%     
==========================================
  Files         319      326       +7     
  Lines        8109     8237     +128     
  Branches     1833     1860      +27     
==========================================
+ Hits         7488     7594     +106     
- Misses        621      643      +22

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aarsilv

So cool to see this starting to be fleshed out! Nice work working through the OpenFeature spec to build out the stubs.

aarsilv · 2025-05-23T04:59:57Z

packages/flagging/README.md

@@ -1,3 +1,27 @@
 # Flagging SDK

 This package supports flagging and experimentation by performing evaluation in the browser.
+
+## Initialize


❤️

Love the quickstart examples!

aarsilv · 2025-05-23T05:00:28Z

packages/flagging/package.json

+    "@openfeature/core": "1.8.0",
+    "@openfeature/web-sdk": "1.5.0"


aarsilv · 2025-05-23T05:00:44Z

packages/flagging/src/openfeature/provider.spec.ts

+import { StandardResolutionReasons, type EvaluationContext, type Logger } from '@openfeature/core'
+import { createDatadogProvider } from './provider'
+
+describe('DatadogProvider', () => {


aarsilv · 2025-05-23T05:06:26Z

packages/flagging/src/openfeature/provider.spec.ts

+
+  describe('resolveBooleanEvaluation', () => {
+    it('should return default value with DEFAULT reason', () => {
+      const result = provider.resolveBooleanEvaluation('test-flag', true, mockContext, mockLogger)


Interesting they want logger as a fourth argument (package docs). It seems it (and context) can be set at the provider level. Is this just for extra flexibility?

@aarsilv I don't see a way to set logger on provider level (in provider API). For context, I guess that helps with context switches and it helps for providers in dynamic-context paradigm.

What's even funnier about logger is that OF discourages any logging in resolve methods

aarsilv · 2025-05-23T05:06:47Z

packages/flagging/src/openfeature/provider.ts

+import { StandardResolutionReasons } from '@openfeature/core'
+import type { Provider } from '@openfeature/web-sdk'
+
+export function createDatadogProvider(): Provider {


aarsilv · 2025-05-23T05:08:21Z

sandbox/react-app/main.tsx

+
+async function initializeOpenFeature() {
+  const datadogFlaggingProvider = createDatadogProvider()
+  await OpenFeature.setContext(subject)


presumably after this is where we could also call setLogger() (package docs)

aarsilv · 2025-05-23T05:08:54Z

sandbox/react-app/main.tsx

+  return (
+    <div>
+      <h1>Home</h1>
+      <h2>Flagging Evaluation</h2>


aarsilv · 2025-05-23T05:09:41Z

scripts/check-licenses.js

  }
-  printLog('Dependencies check done.')
+  throw new Error('Dependencies mismatch')


Thanks for the cleanup and fixing here! 🔧 🧹

packages/flagging/src/openfeature/provider.ts

BenoitZugmeyer · 2025-05-28T08:07:44Z

packages/flagging/package.json

@@ -18,13 +18,18 @@
    "@datadog/browser-core": "6.8.0"
  },
  "peerDependencies": {
-    "@datadog/browser-rum": "6.8.0"
+    "@datadog/browser-rum": "6.8.0",
+    "@openfeature/web-sdk": "1.5.0"


question: is this a peer dependency the customer will need to install to use the flagging package?

Yes. Our provider is a plugin for OpenFeature SDK

LICENSE-3rdparty.csv

scripts/check-licenses.js

…nfeature-2

leoromanovsky · 2025-05-28T14:18:25Z

closing to work on #3571

leoromanovsky force-pushed the leo.romanovsky/flagging-sdk-long-running-openfeature-2 branch 2 times, most recently from 0121d00 to fa988b8 Compare May 22, 2025 20:56

leoromanovsky marked this pull request as ready for review May 22, 2025 21:05

leoromanovsky requested review from a team as code owners May 22, 2025 21:05

leoromanovsky requested review from aarsilv and a team May 22, 2025 21:05

aliciascott approved these changes May 22, 2025

View reviewed changes

leoromanovsky changed the title ~~feat: add openfeature dependency and datadog provider (FFL-24)~~ ✨ [FFL-24] add openfeature dependency and datadog provider May 23, 2025

aarsilv approved these changes May 23, 2025

View reviewed changes

aarsilv assigned leoromanovsky May 23, 2025

leoromanovsky force-pushed the leo.romanovsky/flagging-sdk-long-running-scaffold-1 branch from c32ec4e to d7c9863 Compare May 23, 2025 17:04

Base automatically changed from leo.romanovsky/flagging-sdk-long-running-scaffold-1 to main May 23, 2025 17:53

rasendubi reviewed May 23, 2025

View reviewed changes

packages/flagging/src/openfeature/provider.ts Outdated Show resolved Hide resolved

leoromanovsky force-pushed the leo.romanovsky/flagging-sdk-long-running-openfeature-2 branch from 4a6d5e5 to 02ef932 Compare May 23, 2025 20:33

dd-devflow bot added mergequeue-status: waiting mergequeue-status: removed and removed mergequeue-status: waiting labels May 23, 2025

DataDog deleted a comment from dd-devflow bot May 23, 2025

rasendubi mentioned this pull request May 26, 2025

✨ FFL-16 Precomputed flags evaluation #3571

Draft

4 tasks

leoromanovsky force-pushed the leo.romanovsky/flagging-sdk-long-running-openfeature-2 branch 2 times, most recently from 862769f to 3078f1b Compare May 27, 2025 21:40

✨ [FFL-24] add openfeature dependency and datadog provider

044fd8c

leoromanovsky force-pushed the leo.romanovsky/flagging-sdk-long-running-openfeature-2 branch from 3078f1b to 044fd8c Compare May 27, 2025 22:57

remove openfeature/core

59e15cf

BenoitZugmeyer reviewed May 28, 2025

View reviewed changes

amortemousque reviewed May 28, 2025

View reviewed changes

LICENSE-3rdparty.csv Outdated Show resolved Hide resolved

amortemousque reviewed May 28, 2025

View reviewed changes

scripts/check-licenses.js Outdated Show resolved Hide resolved

leoromanovsky added 5 commits May 28, 2025 06:40

Merge branch 'main' into leo.romanovsky/flagging-sdk-long-running-ope…

e4c0d63

…nfeature-2

rename package

49b7299

3rd party license

6e0f134

fix sandbox

336fea2

fix import

71afc70

leoromanovsky closed this May 28, 2025

leoromanovsky mentioned this pull request May 29, 2025

✨ FFL-16 Precomputed flags evaluation #3580

Open

4 tasks

		"@openfeature/core": "1.8.0",
		"@openfeature/web-sdk": "1.5.0"

✨ [FFL-24] add openfeature dependency and datadog provider #3554

✨ [FFL-24] add openfeature dependency and datadog provider #3554

Uh oh!

Conversation

leoromanovsky commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Changes

Test instructions

Checklist

Uh oh!

codecov-commenter commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

aarsilv left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

leoromanovsky commented May 28, 2025

Uh oh!

Uh oh!

leoromanovsky commented May 22, 2025 •

edited

Loading

codecov-commenter commented May 22, 2025 •

edited

Loading