✨ FFL-16 Precomputed flags evaluation #3571
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rasendubi
changed the title
leoromanovsky
force-pushed
the
leo.romanovsky/flagging-sdk-long-running-openfeature-2
branch
2 times, most recently
from
862769f to
3078f1b
Compare
leoromanovsky
force-pushed
the
leo.romanovsky/flagging-sdk-long-running-openfeature-2
branch
from
3078f1b to
044fd8c
Compare
OpenFeature recommends relying on web-sdk package instead of core. The downside is that web-sdk is not side-effect free, so it's better if we don't depend on StandardResolutionReasons. The good news is that TypeScript should be able to check literals against enum and using 'DEFAULT' literal is shorter and reduces bundle size a bit.
Remove peer dependencies from `dependencies` list. Also use caret range, so users are free to select SDK version.
rasendubi
force-pushed
the
ffe-openfeature
branch
from
2db56e2 to
b4a92c6
Compare
rasendubi
changed the base branch from
leo.romanovsky/flagging-sdk-long-running-openfeature-2
to
main
rasendubi
force-pushed
the
ffe-openfeature
branch
from
d502696 to
6c7ab1b
Compare
4 tasks
rasendubi
commented
May 29, 2025
Comment on lines
+33
to
+50
| ```typescript | ||
| // Initialize RUM with experimental feature flags tracking | ||
| import { datadogRum } from '@datadog/browser-rum'; | ||
|
|
||
| // Initialize Datadog Browser SDK | ||
| datadogRum.init({ | ||
| ... | ||
| enableExperimentalFeatures: ["feature_flags"], | ||
| ... | ||
| }); | ||
|
|
||
| // Add OpenFeature hook | ||
| OpenFeature.addHooks({ | ||
| after(_hookContext: HookContext, details: EvaluationDetails<FlagValue>) { | ||
| datadogRum.addFeatureFlagEvaluation(details.flagKey, details.value) | ||
| } | ||
| }) | ||
| ``` |
There was a problem hiding this comment.
@leoromanovsky here's an example of sending of sending flag evaluation to RUM using existing feature flags implementation
rasendubi
commented
May 29, 2025
| */ | ||
| clientToken: string | ||
|
|
||
| baseUrl: string |
There was a problem hiding this comment.
Don't know what's our default base url is, so this option is required for now
leoromanovsky
approved these changes
May 29, 2025
| "id": "1", | ||
| "data": { | ||
| "attributes": { | ||
| "createdAt": 1731939805123, |
Comment on lines
+101
to
+106
| // type safety: OpenFeature interface requires us to return a | ||
| // specific T for *any* value of T (which could be any subtype of | ||
| // JsonValue). We can't even theoretically implement it in a | ||
| // type-sound way because there's no runtime information passed to | ||
| // learn what type the user expects. So it's up to the user to | ||
| // makesure they pass the appropriate type. |
There was a problem hiding this comment.
yea this is tricky and I am curious as we dogfood it how it "feels"; we'll evolve it to make it easier for our users
| /** | ||
| * Create configuration from a string created with `configurationToString`. | ||
| */ | ||
| export function configurationFromString(s: string): Configuration { |
There was a problem hiding this comment.
embracing classless life and tree-shaking 😅
|
/trigger-ci |
|
View all feedbacks in Devflow UI.
cannot get branch ffe-openfeature from github API: unexpected status code: 404 Not Found (Request ID: 98B1:3DAA79:2CB0579:5816422:68383EED) DetailsIf you need support, contact us on Slack #devflow with those details! |
|
converted to draft because it cannot run CI, branched in #3580 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Precomputed flags evaluation + small fixes on top of #3554.
Changes
See individual commits for more details.
Test instructions
Checklist
cc @leoromanovsky