Skip to content

11 redesign all constructors #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jochenwezel merged 8 commits into from
Dec 18, 2025
Merged

11 redesign all constructors #13

jochenwezel merged 8 commits into from
Dec 18, 2025

Conversation

@jochenwezel
Copy link
Member

@jochenwezel jochenwezel commented Dec 18, 2025 •
edited
Loading

implemented #11

  • redesigned constructors and engine/workbook default options (old constructors remained for compatibility reasons, but marked as obsolete)
  • fixed several issues found in unit tests which were not tested automatically in CI/CD pipeline

@jochenwezel jochenwezel self-assigned this Dec 18, 2025
@jochenwezel jochenwezel linked an issue Dec 18, 2025 that may be closed by this pull request
Redesign all constructors #11
Closed
6 tasks
@github-actions
Copy link

github-actions bot commented Dec 18, 2025 •
edited
Loading

Unit Test Statistics (ubuntu-latest) CompuMaster.MsExcelComInteropTest.dll

2 tests  ±0   2 ✅ ±0   0s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 7044a24. ± Comparison against base commit 589fe1d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 18, 2025 •
edited
Loading

Unit Test Statistics (ubuntu-latest) CompuMaster.Excel.Test.dll

50 tests  ±0   50 ✅ ±0   2s ⏱️ ±0s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 7044a24. ± Comparison against base commit 589fe1d.

This pull request removes 5 and adds 5 tests. Note that renamed tests count towards both. 
CompuMaster.Excel.Test.ExcelOpsTests.MsExcelSpecials.MsExcelAppReleaseTest ‑ OpenAnCloseMsExcelWithProperProcessCleanup_SeparateMsExcelAppWithExplicitQuit
CompuMaster.Excel.Test.ExcelOpsTests.MsExcelSpecials.MsExcelAppReleaseTest ‑ OpenAnCloseMsExcelWithPropertProcessCleanup_ReusedMsExcelApp(False)
CompuMaster.Excel.Test.ExcelOpsTests.MsExcelSpecials.MsExcelAppReleaseTest ‑ OpenAnCloseMsExcelWithPropertProcessCleanup_ReusedMsExcelApp(True)
CompuMaster.Excel.Test.ExcelOpsTests.MsExcelSpecials.MsExcelAppReleaseTest ‑ OpenAnCloseMsExcelWithPropertProcessCleanup_SeparateMsExcelApp(False)
CompuMaster.Excel.Test.ExcelOpsTests.MsExcelSpecials.MsExcelAppReleaseTest ‑ OpenAnCloseMsExcelWithPropertProcessCleanup_SeparateMsExcelApp(True)

CompuMaster.Excel.Test.ExcelOpsTests.MsExcelSpecials.MsExcelAppReleaseTest ‑ OpenAndCloseMsExcelWithProperProcessCleanup_ReusedMsExcelApp(False)
CompuMaster.Excel.Test.ExcelOpsTests.MsExcelSpecials.MsExcelAppReleaseTest ‑ OpenAndCloseMsExcelWithProperProcessCleanup_ReusedMsExcelApp(True)
CompuMaster.Excel.Test.ExcelOpsTests.MsExcelSpecials.MsExcelAppReleaseTest ‑ OpenAndCloseMsExcelWithProperProcessCleanup_SeparateMsExcelApp(False)
CompuMaster.Excel.Test.ExcelOpsTests.MsExcelSpecials.MsExcelAppReleaseTest ‑ OpenAndCloseMsExcelWithProperProcessCleanup_SeparateMsExcelApp(True)
CompuMaster.Excel.Test.ExcelOpsTests.MsExcelSpecials.MsExcelAppReleaseTest ‑ OpenAndCloseMsExcelWithProperProcessCleanup_SeparateMsExcelAppWithExplicitQuit

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 18, 2025 •
edited
Loading

Unit Test Statistics (macos-latest) CompuMaster.MsExcelComInteropTest.dll

2 tests  ±0   2 ✅ ±0   0s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 7044a24. ± Comparison against base commit 589fe1d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 18, 2025 •
edited
Loading

Unit Test Statistics (ubuntu-latest) CompuMaster.Excel.TestFreeSpireXls.dll

6 tests  ±0   6 ✅ ±0   1s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 7044a24. ± Comparison against base commit 589fe1d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 18, 2025 •
edited
Loading

Unit Test Statistics (ubuntu-latest) CompuMaster.Excel.TestSpireXls.dll

6 tests  ±0   6 ✅ ±0   0s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 7044a24. ± Comparison against base commit 589fe1d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 18, 2025 •
edited
Loading

Unit Test Statistics (macos-latest) CompuMaster.Excel.Test.dll

50 tests  ±0   50 ✅ ±0   1s ⏱️ -1s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 7044a24. ± Comparison against base commit 589fe1d.

This pull request removes 5 and adds 5 tests. Note that renamed tests count towards both. 
CompuMaster.Excel.Test.ExcelOpsTests.MsExcelSpecials.MsExcelAppReleaseTest ‑ OpenAnCloseMsExcelWithProperProcessCleanup_SeparateMsExcelAppWithExplicitQuit
CompuMaster.Excel.Test.ExcelOpsTests.MsExcelSpecials.MsExcelAppReleaseTest ‑ OpenAnCloseMsExcelWithPropertProcessCleanup_ReusedMsExcelApp(False)
CompuMaster.Excel.Test.ExcelOpsTests.MsExcelSpecials.MsExcelAppReleaseTest ‑ OpenAnCloseMsExcelWithPropertProcessCleanup_ReusedMsExcelApp(True)
CompuMaster.Excel.Test.ExcelOpsTests.MsExcelSpecials.MsExcelAppReleaseTest ‑ OpenAnCloseMsExcelWithPropertProcessCleanup_SeparateMsExcelApp(False)
CompuMaster.Excel.Test.ExcelOpsTests.MsExcelSpecials.MsExcelAppReleaseTest ‑ OpenAnCloseMsExcelWithPropertProcessCleanup_SeparateMsExcelApp(True)

CompuMaster.Excel.Test.ExcelOpsTests.MsExcelSpecials.MsExcelAppReleaseTest ‑ OpenAndCloseMsExcelWithProperProcessCleanup_ReusedMsExcelApp(False)
CompuMaster.Excel.Test.ExcelOpsTests.MsExcelSpecials.MsExcelAppReleaseTest ‑ OpenAndCloseMsExcelWithProperProcessCleanup_ReusedMsExcelApp(True)
CompuMaster.Excel.Test.ExcelOpsTests.MsExcelSpecials.MsExcelAppReleaseTest ‑ OpenAndCloseMsExcelWithProperProcessCleanup_SeparateMsExcelApp(False)
CompuMaster.Excel.Test.ExcelOpsTests.MsExcelSpecials.MsExcelAppReleaseTest ‑ OpenAndCloseMsExcelWithProperProcessCleanup_SeparateMsExcelApp(True)
CompuMaster.Excel.Test.ExcelOpsTests.MsExcelSpecials.MsExcelAppReleaseTest ‑ OpenAndCloseMsExcelWithProperProcessCleanup_SeparateMsExcelAppWithExplicitQuit

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 18, 2025 •
edited
Loading

Unit Test Statistics (macos-latest) CompuMaster.Excel.TestFreeSpireXls.dll

6 tests  ±0   6 ✅ ±0   1s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 7044a24. ± Comparison against base commit 589fe1d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 18, 2025 •
edited
Loading

Unit Test Statistics (macos-latest) CompuMaster.Excel.TestSpireXls.dll

6 tests  ±0   6 ✅ ±0   0s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 7044a24. ± Comparison against base commit 589fe1d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 18, 2025 •
edited
Loading

Unit Test Statistics (windows-latest) CompuMaster.MsExcelComInteropTest.dll

2 tests  ±0   2 ✅ ±0   0s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 7044a24. ± Comparison against base commit 589fe1d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 18, 2025 •
edited
Loading

Unit Test Statistics (windows-latest) CompuMaster.Excel.Test.dll

216 tests  ±0   216 ✅ ±0   23s ⏱️ -28s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 7044a24. ± Comparison against base commit 589fe1d.

This pull request removes 5 and adds 5 tests. Note that renamed tests count towards both. 
CompuMaster.Excel.Test.ExcelOpsTests.MsExcelSpecials.MsExcelAppReleaseTest ‑ OpenAnCloseMsExcelWithProperProcessCleanup_SeparateMsExcelAppWithExplicitQuit
CompuMaster.Excel.Test.ExcelOpsTests.MsExcelSpecials.MsExcelAppReleaseTest ‑ OpenAnCloseMsExcelWithPropertProcessCleanup_ReusedMsExcelApp(False)
CompuMaster.Excel.Test.ExcelOpsTests.MsExcelSpecials.MsExcelAppReleaseTest ‑ OpenAnCloseMsExcelWithPropertProcessCleanup_ReusedMsExcelApp(True)
CompuMaster.Excel.Test.ExcelOpsTests.MsExcelSpecials.MsExcelAppReleaseTest ‑ OpenAnCloseMsExcelWithPropertProcessCleanup_SeparateMsExcelApp(False)
CompuMaster.Excel.Test.ExcelOpsTests.MsExcelSpecials.MsExcelAppReleaseTest ‑ OpenAnCloseMsExcelWithPropertProcessCleanup_SeparateMsExcelApp(True)

CompuMaster.Excel.Test.ExcelOpsTests.MsExcelSpecials.MsExcelAppReleaseTest ‑ OpenAndCloseMsExcelWithProperProcessCleanup_ReusedMsExcelApp(False)
CompuMaster.Excel.Test.ExcelOpsTests.MsExcelSpecials.MsExcelAppReleaseTest ‑ OpenAndCloseMsExcelWithProperProcessCleanup_ReusedMsExcelApp(True)
CompuMaster.Excel.Test.ExcelOpsTests.MsExcelSpecials.MsExcelAppReleaseTest ‑ OpenAndCloseMsExcelWithProperProcessCleanup_SeparateMsExcelApp(False)
CompuMaster.Excel.Test.ExcelOpsTests.MsExcelSpecials.MsExcelAppReleaseTest ‑ OpenAndCloseMsExcelWithProperProcessCleanup_SeparateMsExcelApp(True)
CompuMaster.Excel.Test.ExcelOpsTests.MsExcelSpecials.MsExcelAppReleaseTest ‑ OpenAndCloseMsExcelWithProperProcessCleanup_SeparateMsExcelAppWithExplicitQuit

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 18, 2025 •
edited
Loading

Unit Test Statistics (windows-latest) CompuMaster.Excel.TestFreeSpireXls.dll

61 tests  ±0   61 ✅ ±0   17s ⏱️ ±0s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 7044a24. ± Comparison against base commit 589fe1d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 18, 2025 •
edited
Loading

Unit Test Statistics (windows-latest) CompuMaster.Excel.TestSpireXls.dll

63 tests  ±0   63 ✅ ±0   17s ⏱️ ±0s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 7044a24. ± Comparison against base commit 589fe1d.

♻️ This comment has been updated with latest results.

@jochenwezel jochenwezel merged commit 157d87d into main Dec 18, 2025
15 checks passed
@jochenwezel jochenwezel deleted the 11-redesign-all-constructors branch December 18, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jochenwezel jochenwezel

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Redesign all constructors

2 participants

@jochenwezel