Skip to content

#350 Bottom Drawer #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Apr 19, 2022
Merged

#350 Bottom Drawer #423

merged 15 commits into from
Apr 19, 2022

Conversation

StefKors
Copy link
Member

@StefKors StefKors commented Apr 12, 2022 •
edited by lukepistrol
Loading

Description

Add the bottom Drawer UI.

  • Toggle full height bottom drawer
  • Tab buttons for Drawer content
  • Icons + Buttons for the various features

Related Issue

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • I documented my code
  • Review requested

Screenshots

Screenshot 2022-04-13 at 01 11 57

@lukepistrol lukepistrol changed the title Draft: #350 Bottom Drawer [WIP] #350 Bottom Drawer Apr 12, 2022
lukepistrol
lukepistrol reviewed Apr 12, 2022
View reviewed changes
Copy link
Member

@lukepistrol lukepistrol left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome. Some things to consider though 😉

Also maybe make the icon a bit wider/thinner.

And be sure to fill out the PR description.

@austincondiff austincondiff linked an issue Apr 13, 2022 that may be closed by this pull request
✨ Bottom Drawer for Utility Area #350
Closed
@lukepistrol lukepistrol mentioned this pull request Apr 13, 2022
Merged
5 tasks
lukepistrol
lukepistrol reviewed Apr 13, 2022
View reviewed changes
lukepistrol
lukepistrol reviewed Apr 13, 2022
View reviewed changes
lukepistrol
lukepistrol reviewed Apr 13, 2022
View reviewed changes
@StefKors StefKors marked this pull request as ready for review April 14, 2022 22:17
@StefKors StefKors requested a review from lukepistrol April 14, 2022 22:17
@StefKors StefKors changed the title [WIP] #350 Bottom Drawer #350 Bottom Drawer Apr 14, 2022
lukepistrol
lukepistrol requested changes Apr 15, 2022
View reviewed changes
Copy link
Member

@lukepistrol lukepistrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The status bar collapses when switching files.
  • When no file is open and you try to drag up the status bar from the collapsed state the app freezes

@lukepistrol lukepistrol added UI This is UI related statusbar and removed information missing labels Apr 15, 2022
@StefKors
Copy link
Member Author

Thanks for the review @lukepistrol I'll fix that asap

@lukepistrol lukepistrol marked this pull request as draft April 16, 2022 18:13
@lukepistrol lukepistrol added the WIP This is work-in-progress label Apr 16, 2022
@lukepistrol lukepistrol changed the title #350 Bottom Drawer [WIP] #350 Bottom Drawer Apr 16, 2022
@StefKors
Copy link
Member Author

The status bar collapses when switching files.

Hi @lukepistrol I fixed this one

When no file is open and you try to drag up the status bar from the collapsed state the app freezes

I spent quite some time debugging this issue. When it's collapsed or almost collapsed it keeps jumping between 0 and a little expanded. Which in turn freezes the app. Any tips on making the drag gesture handle something like that better?

One thing I tried was using a VSplitView that makes the resizing way smoother but I didn't find a way to programmatically set the heights with that view. 🤔

@Angelk90
Copy link
Contributor

@StefKors : Could you post a video of what's happening right now?

@StefKors
Copy link
Member Author

Screen.Recording.2022-04-19.at.11.40.39.mov

@lukepistrol lukepistrol marked this pull request as ready for review April 19, 2022 09:25
lukepistrol
lukepistrol reviewed Apr 19, 2022
View reviewed changes
Copy link
Member

@lukepistrol lukepistrol left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to move the breakpoint symbols into CodeEditSymbols.

I can do so if you want. So we can close/merge this PR. Just let me know!

@lukepistrol lukepistrol merged commit eae9468 into CodeEditApp:main Apr 19, 2022
@austincondiff austincondiff changed the title [WIP] #350 Bottom Drawer #350 Bottom Drawer Apr 19, 2022
@austincondiff austincondiff removed the WIP This is work-in-progress label Apr 19, 2022
@CodeEditApp CodeEditApp deleted a comment from allcontributors bot Apr 19, 2022
@Angelk90
Copy link
Contributor

@StefKors : Some problems.

Registrazione_schermo_2022-04-19_alle_13.37.52.mov
Registrazione_schermo_2022-04-19_alle_13.13.42.mov
Registrazione_schermo_2022-04-19_alle_13.11.24.mov

@austincondiff austincondiff mentioned this pull request Apr 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukepistrol lukepistrol lukepistrol approved these changes

Assignees
No one assigned
Labels
statusbar UI This is UI related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ Bottom Drawer for Utility Area
4 participants
@StefKors @Angelk90 @lukepistrol @austincondiff