Fix user confirm email already exists #11161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianjgeiger
approved these changes
Jun 2, 2025
brianjgeiger
merged commit dc09e8a
into
CenterForOpenScience:feature/pbs-25-10
6 checks passed
Johnetordoff
added a commit
to Johnetordoff/osf.io
that referenced
this pull request
Jun 2, 2025
…cience/osf.io into feature/notification-refactor-phase-1 * 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io: fix issue where trying another already confirmed email threw an uncaught exception (CenterForOpenScience#11161) [ENG-8148] Add ArtifactOutcome in annotations to linked nodes (CenterForOpenScience#11158) [ENG-7966] Add "collected-in" relationship for Nodes (CenterForOpenScience#11140) fix issue where not having any external identities caused a 500 # Conflicts: # api_tests/nodes/views/test_node_detail.py # api_tests/nodes/views/test_node_linked_registrations.py
Johnetordoff
added a commit
to Johnetordoff/osf.io
that referenced
this pull request
Jun 3, 2025
…cience/osf.io into add-new-notifications-data-model * 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io: fix issue where trying another already confirmed email threw an uncaught exception (CenterForOpenScience#11161) [ENG-8148] Add ArtifactOutcome in annotations to linked nodes (CenterForOpenScience#11158)
Johnetordoff
added a commit
to Johnetordoff/osf.io
that referenced
this pull request
Jun 3, 2025
…cience/osf.io into refactor-notifications * 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io: fix issue where trying another already confirmed email threw an uncaught exception (CenterForOpenScience#11161) [ENG-8148] Add ArtifactOutcome in annotations to linked nodes (CenterForOpenScience#11158) [ENG-7966] Add "collected-in" relationship for Nodes (CenterForOpenScience#11140) fix issue where not having any external identities caused a 500 [ENG-7965] Add v2 email token confirmation endpoints (CenterForOpenScience#11139) [ENG-8052] Fixed FilterMixin issue with multiple values of notification subscription field (CenterForOpenScience#11150) support related_counts for view_only links (CenterForOpenScience#11148) allow admins change registration providers (CenterForOpenScience#11145) [ENG-7927] Improved logging for embargo termination (CenterForOpenScience#11137) [ENG-7873] CLONE - SPAM - When Hamming a Spammed user, preprints and registrations remain private (CenterForOpenScience#11125) Update changelog and package.json fix TypeError when check stucked registration revert async email sending (CenterForOpenScience#11134) [ENG-7921] Add scopes for applications to full_read and full_write scopes (CenterForOpenScience#11126) # Conflicts: # api_tests/nodes/views/test_node_detail.py # api_tests/nodes/views/test_node_linked_registrations.py # framework/auth/oauth_scopes.py # tests/test_registrations/test_retractions.py
Johnetordoff
added a commit
to Johnetordoff/osf.io
that referenced
this pull request
Aug 4, 2025
…cience/osf.io into add-has-data-annotations-to-linked-nodes * 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io: Revert "[ENG-8048] Remove caching to avoid incorrect results for ascendants (…" Revert "fixed None issue when iterate (CenterForOpenScience#11192)" fixed None issue when iterate (CenterForOpenScience#11192) [ENG-8048] Remove caching to avoid incorrect results for ascendants (CenterForOpenScience#11169) [ENG-7870] Crossref DOIs not minting with _v1, OSF is displaying DOI versions with _v1 (CenterForOpenScience#11154) Update changelog and package.json [ENG-8145] [ENG-8147] Manual DOI and GUID for Preprints & Registrations - BE (CenterForOpenScience#11174) Update hybrid values for new workflow check (CenterForOpenScience#11166) fix issue where trying another already confirmed email threw an uncaught exception (CenterForOpenScience#11161) [ENG-8148] Add ArtifactOutcome in annotations to linked nodes (CenterForOpenScience#11158)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
If user email already existed the error was uncaught.
Changes
QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket