[ENG-7927] Improved logging for embargo termination #11137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianjgeiger
approved these changes
May 12, 2025
brianjgeiger
requested changes
May 12, 2025
| f'Unexpected error raised when completing embargo for ' | ||
| f'registration {parent_registration._id}. Continuing...' | ||
| f'Registration {parent_registration._id} could not be made public because {str(err)}', | ||
| exc_info=err |
There was a problem hiding this comment.
Based on other places I've seen it used, exc_info should be a boolean.
There was a problem hiding this comment.
Before this change I checked the source code of the lib and it supports childs of BaseException class
brianjgeiger
approved these changes
May 12, 2025
brianjgeiger
merged commit bcd86db
into
CenterForOpenScience:feature/pbs-25-10
6 checks passed
Johnetordoff
added a commit
to Johnetordoff/osf.io
that referenced
this pull request
Jun 3, 2025
…cience/osf.io into refactor-notifications * 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io: fix issue where trying another already confirmed email threw an uncaught exception (CenterForOpenScience#11161) [ENG-8148] Add ArtifactOutcome in annotations to linked nodes (CenterForOpenScience#11158) [ENG-7966] Add "collected-in" relationship for Nodes (CenterForOpenScience#11140) fix issue where not having any external identities caused a 500 [ENG-7965] Add v2 email token confirmation endpoints (CenterForOpenScience#11139) [ENG-8052] Fixed FilterMixin issue with multiple values of notification subscription field (CenterForOpenScience#11150) support related_counts for view_only links (CenterForOpenScience#11148) allow admins change registration providers (CenterForOpenScience#11145) [ENG-7927] Improved logging for embargo termination (CenterForOpenScience#11137) [ENG-7873] CLONE - SPAM - When Hamming a Spammed user, preprints and registrations remain private (CenterForOpenScience#11125) Update changelog and package.json fix TypeError when check stucked registration revert async email sending (CenterForOpenScience#11134) [ENG-7921] Add scopes for applications to full_read and full_write scopes (CenterForOpenScience#11126) # Conflicts: # api_tests/nodes/views/test_node_detail.py # api_tests/nodes/views/test_node_linked_registrations.py # framework/auth/oauth_scopes.py # tests/test_registrations/test_retractions.py
ihorsokhanexoft
added a commit
to ihorsokhanexoft/osf.io
that referenced
this pull request
Jun 4, 2025
…ence#11137) ## Purpose Embargo termination logging doesn't provide useful info regarding of what error was raised ## Changes Improved logging, removed if statement duplicate ## Ticket https://openscience.atlassian.net/browse/ENG-7927
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Embargo termination logging doesn't provide useful info regarding of what error was raised
Changes
Improved logging, removed if statement duplicate
Ticket
https://openscience.atlassian.net/browse/ENG-7927?atlOrigin=eyJpIjoiZDJkYTQ3MjdmN2UxNDBjYmIzMDg1YzVhNmI4ZjMzMWQiLCJwIjoiaiJ9