Add virtualenv prompt for robbyrussell theme #2060
Conversation
davidpfarrell
left a comment
davidpfarrell
left a comment
There was a problem hiding this comment.
Greetings and thanks for submitting a PR !
I have a comment regarding placement of the new prompt - feels a bit out of place at the very start of the prompt line ... My suggestion would be to place it after the scm prompt segment ...
petarnikolovski
force-pushed
the
master
branch
from
818f095 to
1ec8f9d
Compare
gaelicWizard
left a comment
gaelicWizard
left a comment
There was a problem hiding this comment.
Seems we already have a variation on venv_prompt! It would be better to use, or enhance, those rather than create a duplicate.
gaelicWizard
left a comment
gaelicWizard
left a comment
There was a problem hiding this comment.
Looks great to me! 😃
|
@davidpfarrell @gaelicWizard any update on this, is it ready to be merged? |
| function conda_or_venv_prompt() { | ||
| local python_venv="" | ||
| if [[ -n "${CONDA_DEFAULT_ENV:-}" ]]; then | ||
| python_venv=$(condaenv_prompt) | ||
| PYTHON_VENV_CHAR=${CONDA_PYTHON_VENV_CHAR} | ||
| elif [[ -n "${VIRTUAL_ENV:-}" ]]; then | ||
| python_venv=$(virtualenv_prompt) | ||
| fi | ||
| [[ -n "${python_venv}" ]] && echo "${PYTHON_VENV_CHAR}${python_venv}" | ||
| } |
There was a problem hiding this comment.
This function should probably live closer to the existing functions.
NOTE: PYTHON_VENV_CHAR and CONDA_PYTHON_VENV_CHAR are only used by the themes that do not invoke the virtualenv_prompt or condaenv_prompt functions. Those function use PYTHON_THEME_PROMPT_PREFIX and PYTHON_THEME_PROMPT_SUFFIX
The spirit of the methods that live in this base theme is to use the PREFIX and SUFFIX variables.
I think this function just becomes:
if [[ -n "${CONDA_DEFAULT_ENV:-}" ]]; then
condaenv_prompt
elif [[ -n "${VIRTUAL_ENV:-}" ]]; then
virtualenv_prompt
fi
There was a problem hiding this comment.
hi @petarnikolovski, want to continue and improve this?
There was a problem hiding this comment.
@NoahGorny Sorry for the late response, I will make moves on improvement soon, I couldn't manage because of my work schedule.
|
Hey there @petarnikolovski , do you want to finish this PR, or merge it as is? |
seefood
added
seems abandoned
|
@seefood Hi, I'm swamped with work and cannot continue working on this. I'm ok with the merge as is. Otherwise, we can close this. |
|
@petarnikolovski ok, I'll circle back to it some day, I want to make sure I understood the affect correctly. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| RVM_THEME_PROMPT_PREFIX="|" | ||
| RVM_THEME_PROMPT_SUFFIX="|" | ||
|
|
||
| VIRTUALENV_THEME_PROMPT_PREFIX='(' |
Check warning
Code scanning / shellcheck
SC2034 Warning
| RVM_THEME_PROMPT_SUFFIX="|" | ||
|
|
||
| VIRTUALENV_THEME_PROMPT_PREFIX='(' | ||
| VIRTUALENV_THEME_PROMPT_SUFFIX=') ' |
Check warning
Code scanning / shellcheck
SC2034 Warning
6 participants
Description
Added virtualenv prompt for robbyrussell theme (same as in the purity theme)
Motivation and Context
Usually when one
cdinto directory with active virtualenv name of the virtualenv is displayed on the left hand side in parentheses.How Has This Been Tested?
cd into and out of the directory with virtualenv has desired effect
Screenshots (if appropriate):
https://imgur.com/D0ZG5Nc
Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.