Help us clean up Bash-it!

[NoahGorny]

Hello folks!
We have now integrated pre-commit hooks in order to improve the codebase quality. and now we need to start going through the files. We invite anyone who wants to contribute to this effort to try this out:

• Choose a file in the project, which is not present in clean_files.txt
• Add the path from the root of the project to the file in clean_files.txt
• Run ./lint_clean_files.sh, and fix the issues
• When pre-commit runs successfully, feel free to open a PR
• Hooray, you helped us make Bash-it better! 😄

An example PR, would be #1695

[tbhaxor]

Pre commit can be ignore using --no-verify and it will also frustrate the contributor when they are working on too many commits. So I would recommend you to add these checking tasks in the github workflow

[tbhaxor]

I will help you refactoring bash-it

[NoahGorny]

Pre commit can be ignore using --no-verify and it will also frustrate the contributor when they are working on too many commits. So I would recommend you to add these checking tasks in the github workflow

It is indeed pretty frustrating, but checked in the CI (see lint stage)

Also see #1746 for better instructions

Thanks you @tbhaxor for helping us ❤️

[tbhaxor]

Hey @NoahGorny I found so much inconsistent code in plugins directory. 😄

[NoahGorny]

Hey @NoahGorny I found so much inconsistent code in plugins directory. smile

Hi @tbhaxor, there is indeed a lot of inconsistent code in the plugins (and in the rest of the codebase as well). It does not mean we should give up though! We can continue improving the codebase, one PR at a time 😄

[cornfeedhobo]

@tbhaxor haha indeed. Luckily, @NoahGorny has been putting in an amazing amount of effort into figuring out our contribution guidelines and tooling. I see a bright future ahead, especially with great contributors like you helping us clean everything up!! :)